Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2053483002: Remove even more const casting from core. (Closed)

Created:
4 years, 6 months ago by Tom Sepez
Modified:
4 years, 6 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove even more const casting from core. Make the return types/arguments match reality. Committed: https://pdfium.googlesource.com/pdfium/+/6aac8a822ef227b80173f23ea3169b28a6712bba

Patch Set 1 #

Patch Set 2 : Fix non-xfa build. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -11 lines) Patch
M core/fpdfapi/fpdf_font/include/cpdf_font.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfdoc/doc_form.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M core/fpdfdoc/doc_utils.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/fpdfdoc/include/fpdf_doc.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/include/fx_font.h View 1 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Tom Sepez
Dan, pls review.
4 years, 6 months ago (2016-06-08 20:50:53 UTC) #2
dsinclair
lgtm
4 years, 6 months ago (2016-06-08 20:51:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053483002/1
4 years, 6 months ago (2016-06-08 20:51:58 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac on master.tryserver.client.pdfium (JOB_FAILED, https://build.chromium.org/p/tryserver.client.pdfium/builders/mac/builds/1014) mac_no_v8 on master.tryserver.client.pdfium (JOB_FAILED, ...
4 years, 6 months ago (2016-06-08 20:53:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053483002/20001
4 years, 6 months ago (2016-06-08 21:17:09 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 21:17:28 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/6aac8a822ef227b80173f23ea3169b28a671...

Powered by Google App Engine
This is Rietveld 408576698