Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Issue 2053473002: Prevent playback looping after pause. (Closed)

Created:
4 years, 6 months ago by Tima Vaisburd
Modified:
4 years, 6 months ago
Reviewers:
qinmin
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, avayvod+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-media_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prevent playback looping after pause. Check is_playing_ vatiable in WMPA::OnPlaybackComplete before restarting the player. BUG=616772 Committed: https://crrev.com/8b8ca53230694ddbaa23efa1042c9f887058e88c Cr-Commit-Position: refs/heads/master@{#398710}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/renderer/media/android/webmediaplayer_android.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
Tima Vaisburd
Min, do you think this would be enough?
4 years, 6 months ago (2016-06-08 19:15:29 UTC) #2
qinmin
lgtm
4 years, 6 months ago (2016-06-08 21:13:23 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053473002/1
4 years, 6 months ago (2016-06-08 21:18:04 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-08 22:42:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053473002/1
4 years, 6 months ago (2016-06-08 22:43:53 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-08 22:48:48 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 22:50:25 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8b8ca53230694ddbaa23efa1042c9f887058e88c
Cr-Commit-Position: refs/heads/master@{#398710}

Powered by Google App Engine
This is Rietveld 408576698