Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1362)

Issue 2053463003: Use the doc rect to figure out how many pages there are (Closed)

Created:
4 years, 6 months ago by rhogan
Modified:
4 years, 6 months ago
Reviewers:
Xianzhu
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, mstensho (USE GERRIT), slimming-paint-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@617553
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use the doc rect to figure out how many pages there are When painting fixed pos objects on every page of paged media use the doc's rects when figuring out the number of pages to paint. BUG=618230 Committed: https://crrev.com/d166578a858010f5dd9f2569bc5e5fb07f255b92 Cr-Commit-Position: refs/heads/master@{#399547}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Updated #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -4 lines) Patch
A third_party/WebKit/LayoutTests/printing/fixed-positioned-child-repeats-even-when-html-and-body-are-zero-height.html View 1 chunk +15 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/printing/fixed-positioned-child-repeats-even-when-html-and-body-are-zero-height-expected.html View 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp View 1 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
rhogan
4 years, 6 months ago (2016-06-08 20:06:55 UTC) #2
Xianzhu
https://codereview.chromium.org/2053463003/diff/1/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp File third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp (right): https://codereview.chromium.org/2053463003/diff/1/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp#newcode488 third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp:488: // TODO(rhogan): Figure out the correct behaviour for vertical ...
4 years, 6 months ago (2016-06-08 21:14:06 UTC) #3
rhogan
On 2016/06/08 at 21:14:06, wangxianzhu wrote: > https://codereview.chromium.org/2053463003/diff/1/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp > File third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp (right): > > https://codereview.chromium.org/2053463003/diff/1/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp#newcode488 ...
4 years, 6 months ago (2016-06-08 21:23:57 UTC) #4
rhogan
On 2016/06/08 at 21:23:57, rhogan wrote: > On 2016/06/08 at 21:14:06, wangxianzhu wrote: > > ...
4 years, 6 months ago (2016-06-10 17:51:24 UTC) #5
rhogan
On 2016/06/10 at 17:51:24, rhogan wrote: > > I think our treatment of fixed pos ...
4 years, 6 months ago (2016-06-13 19:47:23 UTC) #6
Xianzhu
lgtm
4 years, 6 months ago (2016-06-13 19:48:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053463003/20001
4 years, 6 months ago (2016-06-13 20:11:09 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-13 21:28:25 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-13 21:28:41 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 21:30:02 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d166578a858010f5dd9f2569bc5e5fb07f255b92
Cr-Commit-Position: refs/heads/master@{#399547}

Powered by Google App Engine
This is Rietveld 408576698