Use the doc rect to figure out how many pages there are

Use the doc rect to figure out how many pages there are

When painting fixed pos objects on every page of paged media use the
doc's rects when figuring out the number of pages to paint.

BUG=618230
Committed: https://crrev.com/d166578a858010f5dd9f2569bc5e5fb07f255b92
Cr-Commit-Position: refs/heads/master@{#399547}

[rhogan, 2016-06-08 20:06:51]

robhogan@gmail.com changed reviewers:
+ wangxianzhu@chromium.org

[Xianzhu, 2016-06-08 21:14:06]

https://codereview.chromium.org/2053463003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp (right):

https://codereview.chromium.org/2053463003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp:488: // TODO(rhogan):
Figure out the correct behaviour for vertical writing modes.
Can you address the vertical writing mode issue (which is introduced by this
patch) in this patch to avoid regression? I think you can just use:
  int documentLogicalHeight = isHorizontal ? view->documentRect().height() :
view->documentRect().width();

[rhogan, 2016-06-08 21:23:57]

On 2016/06/08 at 21:14:06, wangxianzhu wrote:
>
https://codereview.chromium.org/2053463003/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp (right):
> 
>
https://codereview.chromium.org/2053463003/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp:488: //
TODO(rhogan): Figure out the correct behaviour for vertical writing modes.
> Can you address the vertical writing mode issue (which is introduced by this
patch) in this patch to avoid regression? I think you can just use:
>   int documentLogicalHeight = isHorizontal ? view->documentRect().height() :
view->documentRect().width();

And that's what I was going to do, but I wasn't sure what to expect in my layout
tests. I'll include the test I have in a new CL and you can tell me if I'm in
the right direction.

[rhogan, 2016-06-10 17:51:24]

On 2016/06/08 at 21:23:57, rhogan wrote:
> On 2016/06/08 at 21:14:06, wangxianzhu wrote:
> >
https://codereview.chromium.org/2053463003/diff/1/third_party/WebKit/Source/c...
> > File third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp (right):
> > 
> >
https://codereview.chromium.org/2053463003/diff/1/third_party/WebKit/Source/c...
> > third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp:488: //
TODO(rhogan): Figure out the correct behaviour for vertical writing modes.
> > Can you address the vertical writing mode issue (which is introduced by this
patch) in this patch to avoid regression? I think you can just use:
> >   int documentLogicalHeight = isHorizontal ? view->documentRect().height() :
view->documentRect().width();
> 
> And that's what I was going to do, but I wasn't sure what to expect in my
layout tests. I'll include the test I have in a new CL and you can tell me if
I'm in the right direction.

I think our treatment of fixed pos objects in paged media is problematic
regardless of my CLs, I've opened crbug.com/619094 to take a look into it before
trying to do the right thing when making them repeat.

[rhogan, 2016-06-13 19:47:23]

On 2016/06/10 at 17:51:24, rhogan wrote:
> 
> I think our treatment of fixed pos objects in paged media is problematic
regardless of my CLs, I've opened crbug.com/619094 to take a look into it before
trying to do the right thing when making them repeat.

HI wangxianzhu, can you take a look at the updated CL?

[Xianzhu, 2016-06-13 19:48:51]

lgtm

[rhogan, 2016-06-13 20:10:34]

The CQ bit was checked by robhogan@gmail.com

[commit-bot: I haz the power, 2016-06-13 20:11:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2053463003/20001

[commit-bot: I haz the power, 2016-06-13 21:28:25]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-13 21:28:41]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-13 21:30:01]

Description was changed from

==========
Use the doc rect to figure out how many pages there are

When painting fixed pos objects on every page of paged media use the
doc's rects when figuring out the number of pages to paint.

BUG=618230
==========

to

==========
Use the doc rect to figure out how many pages there are

When painting fixed pos objects on every page of paged media use the
doc's rects when figuring out the number of pages to paint.

BUG=618230

Committed: https://crrev.com/d166578a858010f5dd9f2569bc5e5fb07f255b92
Cr-Commit-Position: refs/heads/master@{#399547}
==========

[commit-bot: I haz the power, 2016-06-13 21:30:02]

Patchset 2 (id:??) landed as
https://crrev.com/d166578a858010f5dd9f2569bc5e5fb07f255b92
Cr-Commit-Position: refs/heads/master@{#399547}