Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(902)

Issue 205343010: Use FontPlatformDataHarfBuzz.h on Windows (Closed)

Created:
6 years, 9 months ago by eae
Modified:
6 years, 9 months ago
Reviewers:
dglazkov
CC:
blink-reviews, jamesr, krit, dsinclair, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Visibility:
Public.

Description

Use FontPlatformDataHarfBuzz.h on Windows Merge FontPlatformDataWin.h with FontPlatformDataHarfBuzz.h and use the same version of the FontPlatformData class defintion/header on Windows as on linux, chromeos and android. R=dglazkov@chromium.org BUG=355806 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170088

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -160 lines) Patch
M Source/platform/blink_platform.gyp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/blink_platform.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/fonts/FontPlatformData.h View 1 chunk +2 lines, -4 lines 0 comments Download
M Source/platform/fonts/harfbuzz/FontPlatformDataHarfBuzz.h View 4 chunks +18 lines, -28 lines 0 comments Download
M Source/platform/fonts/harfbuzz/FontPlatformDataHarfBuzz.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/platform/fonts/win/FontCacheSkiaWin.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
D Source/platform/fonts/win/FontPlatformDataWin.h View 1 chunk +0 lines, -121 lines 0 comments Download
M Source/platform/fonts/win/FontPlatformDataWin.cpp View 4 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
eae
Continuing my quest to simplify our font code and reduce code duplication.
6 years, 9 months ago (2014-03-26 03:49:25 UTC) #1
eae
6 years, 9 months ago (2014-03-26 16:41:19 UTC) #2
dglazkov
lgtm
6 years, 9 months ago (2014-03-26 16:43:02 UTC) #3
eae
The CQ bit was checked by eae@chromium.org
6 years, 9 months ago (2014-03-26 16:43:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/205343010/1
6 years, 9 months ago (2014-03-26 16:43:33 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-26 16:46:14 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on blink_presubmit
6 years, 9 months ago (2014-03-26 16:46:14 UTC) #7
eae
The CQ bit was checked by eae@chromium.org
6 years, 9 months ago (2014-03-26 16:46:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/205343010/1
6 years, 9 months ago (2014-03-26 16:46:49 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-26 18:03:43 UTC) #10
commit-bot: I haz the power
Failed to apply patch for Source/platform/blink_platform.gypi: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 9 months ago (2014-03-26 18:03:44 UTC) #11
eae
The CQ bit was checked by eae@chromium.org
6 years, 9 months ago (2014-03-26 18:10:12 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/205343010/80001
6 years, 9 months ago (2014-03-26 18:10:14 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-26 18:12:48 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on blink_presubmit
6 years, 9 months ago (2014-03-26 18:12:49 UTC) #15
eae
The CQ bit was checked by eae@chromium.org
6 years, 9 months ago (2014-03-26 18:20:33 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/205343010/80001
6 years, 9 months ago (2014-03-26 18:20:41 UTC) #17
commit-bot: I haz the power
6 years, 9 months ago (2014-03-26 19:17:15 UTC) #18
Message was sent while issue was closed.
Change committed as 170088

Powered by Google App Engine
This is Rietveld 408576698