Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issue 205343009: Hoist compositorDrivenAcceleratedScrollingEnabled check out of scrollParent (Closed)

Created:
6 years, 9 months ago by abarth-chromium
Modified:
6 years, 9 months ago
Reviewers:
esprehn
CC:
esprehn, abarth-chromium, bemjb+rendering_chromium.org, blink-layers+watch_chromium.org, blink-reviews, dsinclair, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, ojan, pdr., rune+blink, Ian Vollick, zoltan1
Visibility:
Public.

Description

Hoist compositorDrivenAcceleratedScrollingEnabled check out of scrollParent This CL moves the compositorDrivenAcceleratedScrollingEnabled check out of scrollParent so that it's clearer in the callers that this code only does something when this setting is enabled. In compositorDrivenAcceleratedScrollingEnabled, this lets us call compositorDrivenAcceleratedScrollingEnabled once instead of twice, which is faster. In a future CL, I'll cache compositorDrivenAcceleratedScrollingEnabled as a compositing trigger, which will make this code actually go fast. This CL also reorders a bunch of methods in CompositingReasonFinder.cpp to make it clearer which of these functions are called during style recalc and which are call unconditionally on all RenderLayers. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169992

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -74 lines) Patch
M Source/core/rendering/RenderLayer.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/rendering/compositing/CompositedLayerMapping.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/compositing/CompositingReasonFinder.cpp View 5 chunks +71 lines, -69 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
abarth-chromium
6 years, 9 months ago (2014-03-25 23:13:25 UTC) #1
esprehn
lgtm
6 years, 9 months ago (2014-03-25 23:19:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/205343009/1
6 years, 9 months ago (2014-03-25 23:19:21 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-26 00:20:30 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-26 00:20:30 UTC) #5
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 9 months ago (2014-03-26 00:24:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/205343009/1
6 years, 9 months ago (2014-03-26 00:24:25 UTC) #7
esprehn
6 years, 9 months ago (2014-03-26 00:39:10 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-26 00:58:20 UTC) #9
Message was sent while issue was closed.
Change committed as 169992

Powered by Google App Engine
This is Rietveld 408576698