Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Unified Diff: src/gpu/effects/GrDistanceFieldTextureEffect.cpp

Issue 205343008: Distance field fixes for Android (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Fix int->float conversion issues Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/gpu/effects/GrDistanceFieldTextureEffect.h ('k') | src/gpu/gl/GrGLCaps.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/gpu/effects/GrDistanceFieldTextureEffect.cpp
diff --git a/src/gpu/effects/GrDistanceFieldTextureEffect.cpp b/src/gpu/effects/GrDistanceFieldTextureEffect.cpp
index 9159a701e32a966bbb0ba1a3d465b35cd3abc6d2..dd370b6d4e66e32e37ff4f638c50d66015be1087 100755
--- a/src/gpu/effects/GrDistanceFieldTextureEffect.cpp
+++ b/src/gpu/effects/GrDistanceFieldTextureEffect.cpp
@@ -23,7 +23,7 @@ public:
GrGLDistanceFieldTextureEffect(const GrBackendEffectFactory& factory,
const GrDrawEffect& drawEffect)
: INHERITED (factory)
- , fTextureSize(SkSize::Make(-1.f,-1.f)) {}
+ , fTextureSize(SkISize::Make(-1,-1)) {}
virtual void emitCode(GrGLFullShaderBuilder* builder,
const GrDrawEffect& drawEffect,
@@ -35,6 +35,8 @@ public:
SkASSERT(1 == drawEffect.castEffect<GrDistanceFieldTextureEffect>().numVertexAttribs());
SkAssertResult(builder->enableFeature(GrGLShaderBuilder::kStandardDerivatives_GLSLFeature));
+ const GrDistanceFieldTextureEffect& dfTexEffect =
+ drawEffect.castEffect<GrDistanceFieldTextureEffect>();
SkString fsCoordName;
const char* vsCoordName;
@@ -61,16 +63,37 @@ public:
// we adjust for the effect of the transformation on the distance by using
// the length of the gradient of the texture coordinates. We use st coordinates
// to ensure we're mapping 1:1 from texel space to pixel space.
- builder->fsCodeAppendf("\tvec2 st = %s*%s;\n", fsCoordName.c_str(), textureSizeUniName);
- builder->fsCodeAppend("\tvec2 Jdx = dFdx(st);\n");
- builder->fsCodeAppend("\tvec2 Jdy = dFdy(st);\n");
- builder->fsCodeAppend("\tvec2 st_grad = normalize(st);\n");
- builder->fsCodeAppend("\tvec2 grad = vec2(st_grad.x*Jdx.x + st_grad.y*Jdy.x,\n");
- builder->fsCodeAppend("\t st_grad.x*Jdx.y + st_grad.y*Jdy.y);\n");
-
- // this gives us a smooth step across approximately one fragment
- // (assuming a radius of the diagonal of the fragment, hence a factor of sqrt(2)/2)
- builder->fsCodeAppend("\tfloat afwidth = 0.7071*length(grad);\n");
+ builder->fsCodeAppendf("\tvec2 uv = %s;\n", fsCoordName.c_str());
+ builder->fsCodeAppendf("\tvec2 st = uv*%s;\n", textureSizeUniName);
+ builder->fsCodeAppend("\tfloat afwidth;\n");
+ if (dfTexEffect.isUniformScale()) {
+ // this gives us a smooth step across approximately one fragment
+ // (assuming a radius of the diagonal of the fragment, hence a factor of sqrt(2)/2)
+ builder->fsCodeAppend("\tafwidth = 0.7071*dFdx(st.x);\n");
+ } else {
+ builder->fsCodeAppend("\tvec2 Jdx = dFdx(st);\n");
+ builder->fsCodeAppend("\tvec2 Jdy = dFdy(st);\n");
+
+ builder->fsCodeAppend("\tvec2 uv_grad;\n");
+ if (builder->ctxInfo().caps()->dropsTileOnZeroDivide()) {
+ // this is to compensate for the Adreno, which likes to drop tiles on division by 0
+ builder->fsCodeAppend("\tfloat uv_len2 = dot(uv, uv);\n");
+ builder->fsCodeAppend("\tif (uv_len2 < 0.0001) {\n");
+ builder->fsCodeAppend("\t\tuv_grad = vec2(0.7071, 0.7071);\n");
+ builder->fsCodeAppend("\t} else {\n");
+ builder->fsCodeAppend("\t\tuv_grad = uv*inversesqrt(uv_len2);\n");
+ builder->fsCodeAppend("\t}\n");
+ } else {
+ builder->fsCodeAppend("\tuv_grad = normalize(uv);\n");
+ }
+ builder->fsCodeAppend("\tvec2 grad = vec2(uv_grad.x*Jdx.x + uv_grad.y*Jdy.x,\n");
+ builder->fsCodeAppend("\t uv_grad.x*Jdx.y + uv_grad.y*Jdy.y);\n");
+
+ // this gives us a smooth step across approximately one fragment
+ // (assuming a radius of the diagonal of the fragment, hence a factor of sqrt(2)/2)
+ builder->fsCodeAppend("\tafwidth = 0.7071*length(grad);\n");
+ }
+
builder->fsCodeAppend("\tfloat val = smoothstep(-afwidth, afwidth, distance);\n");
builder->fsCodeAppendf("\t%s = %s;\n", outputColor,
@@ -80,20 +103,27 @@ public:
virtual void setData(const GrGLUniformManager& uman,
const GrDrawEffect& drawEffect) SK_OVERRIDE {
SkASSERT(fTextureSizeUni.isValid());
- const GrDistanceFieldTextureEffect& distanceFieldEffect =
- drawEffect.castEffect<GrDistanceFieldTextureEffect>();
- if (distanceFieldEffect.getSize().width() != fTextureSize.width() ||
- distanceFieldEffect.getSize().height() != fTextureSize.height()) {
- fTextureSize = distanceFieldEffect.getSize();
+
+ GrTexture* texture = drawEffect.effect()->get()->texture(0);
+ if (texture->width() != fTextureSize.width() ||
+ texture->height() != fTextureSize.height()) {
+ fTextureSize = SkISize::Make(texture->width(), texture->height());
uman.set2f(fTextureSizeUni,
- distanceFieldEffect.getSize().width(),
- distanceFieldEffect.getSize().height());
+ SkIntToScalar(fTextureSize.width()),
+ SkIntToScalar(fTextureSize.height()));
}
}
+ static inline EffectKey GenKey(const GrDrawEffect& drawEffect, const GrGLCaps&) {
+ const GrDistanceFieldTextureEffect& dfTexEffect =
+ drawEffect.castEffect<GrDistanceFieldTextureEffect>();
+
+ return dfTexEffect.isUniformScale() ? 0x1 : 0x0;
+ }
+
private:
GrGLUniformManager::UniformHandle fTextureSizeUni;
- SkSize fTextureSize;
+ SkISize fTextureSize;
typedef GrGLVertexEffect INHERITED;
};
@@ -102,9 +132,9 @@ private:
GrDistanceFieldTextureEffect::GrDistanceFieldTextureEffect(GrTexture* texture,
const GrTextureParams& params,
- const SkISize& size)
+ bool uniformScale)
: fTextureAccess(texture, params)
- , fSize(SkSize::Make(SkIntToScalar(size.width()), SkIntToScalar(size.height()))) {
+ , fUniformScale(uniformScale) {
this->addTextureAccess(&fTextureAccess);
this->addVertexAttrib(kVec2f_GrSLType);
}
@@ -149,7 +179,6 @@ GrEffectRef* GrDistanceFieldTextureEffect::TestCreate(SkRandom* random,
};
GrTextureParams params(tileModes, random->nextBool() ? GrTextureParams::kBilerp_FilterMode :
GrTextureParams::kNone_FilterMode);
- SkISize size = SkISize::Make(1024, 2048);
- return GrDistanceFieldTextureEffect::Create(textures[texIdx], params, size);
+ return GrDistanceFieldTextureEffect::Create(textures[texIdx], params, random->nextBool());
}
« no previous file with comments | « src/gpu/effects/GrDistanceFieldTextureEffect.h ('k') | src/gpu/gl/GrGLCaps.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698