Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 205343003: [GCM] Add port 443 fallback logic and histograms (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments, update tests Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 13febe87bdd144ee592cdb25a190e88e32c5e546..b054620dc332e220bfb28307b4f75b72bb9bcafd 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -6561,11 +6561,24 @@ other types of suffix sets.
<summary>Status code of the outcome of a GCM checkin request.</summary>
</histogram>
+<histogram name="GCM.ConnectedViaProxy" enum="Boolean">
+ <owner>zea@chromium.org</owner>
+ <summary>Whether the GCM connection was made via a proxy or not.</summary>
+</histogram>
+
<histogram name="GCM.ConnectionDisconnectErrorCode" enum="NetErrorCodes">
<owner>zea@chromium.org</owner>
<summary>Net error results from GCM disconnect events.</summary>
</histogram>
+<histogram name="GCM.ConnectionEndpoint">
+ <owner>zea@chromium.org</owner>
+ <summary>
+ Index of the MCS endpoint to which a connection was made. See
+ gcm_client_impl.cc for endpoint definitions.
+ </summary>
+</histogram>
+
<histogram name="GCM.ConnectionFailureErrorCode" enum="NetErrorCodes">
<owner>zea@chromium.org</owner>
<summary>Net error results from GCM connection attempts.</summary>
@@ -6576,7 +6589,7 @@ other types of suffix sets.
<summary>Reasons for GCM connection resets.</summary>
</histogram>
-<histogram name="GCM.ConnectionSuccessRate">
+<histogram name="GCM.ConnectionSuccessRate" enum="BooleanSuccess">
<owner>zea@chromium.org</owner>
<summary>
GCM connection success rate. Does not take into account login success. See
« google_apis/gcm/engine/connection_factory_impl.cc ('K') | « google_apis/gcm/gcm_client_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698