Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2053393004: Parser: reuse has_extends, instead of doing a check again (Closed)

Created:
4 years, 6 months ago by gsathya
Modified:
4 years, 6 months ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Parser: reuse has_extends, instead of doing a check again Committed: https://crrev.com/604445b55b6e0753c679ba9c9b2621445301fbba Cr-Commit-Position: refs/heads/master@{#36905}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/parsing/parser.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053393004/1
4 years, 6 months ago (2016-06-11 00:10:37 UTC) #2
gsathya
4 years, 6 months ago (2016-06-11 00:10:49 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-11 00:44:22 UTC) #6
Dan Ehrenberg
lgtm
4 years, 6 months ago (2016-06-11 00:56:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053393004/1
4 years, 6 months ago (2016-06-11 01:18:29 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-11 01:20:36 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-11 01:22:46 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/604445b55b6e0753c679ba9c9b2621445301fbba
Cr-Commit-Position: refs/heads/master@{#36905}

Powered by Google App Engine
This is Rietveld 408576698