Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2053393003:
Track password field id so it can be used to improve uniqueness of passwordId (Closed)
DescriptionTrack password field id so it can be used to improve uniqueness of passwordId
BUG=618717
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/8623bfce0e587884b73a85e0106059a46d598f2d
Cr-Commit-Position: refs/heads/master@{#399266}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Track password field id so it can be used to improve uniqueness of passwordId #Messages
Total messages: 18 (8 generated)
Description was changed from ========== Track password field id so it can be used to improve uniqueness of passwordId BUG=crbug:618717 ========== to ========== Track password field id so it can be used to improve uniqueness of passwordId BUG=crbug:618717 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== Track password field id so it can be used to improve uniqueness of passwordId BUG=crbug:618717 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== Track password field id so it can be used to improve uniqueness of passwordId BUG=618717 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
jayhlee@google.com changed reviewers: + afakhry@chromium.org, bartfab@chromium.org, guohui@chromium.org, xiyuan@chromium.org
Thank you for fixing this. https://codereview.chromium.org/2053393003/diff/1/chrome/browser/resources/ga... File chrome/browser/resources/gaia_auth/saml_injected.js (right): https://codereview.chromium.org/2053393003/diff/1/chrome/browser/resources/ga... chrome/browser/resources/gaia_auth/saml_injected.js:146: var fieldId = passwordField.id; It is possible that the IdP page does not set "id" for the password field. Let's give it some fall back values, something like, var fieldId = passwordField.id || passwordField.name || ''; https://codereview.chromium.org/2053393003/diff/1/chrome/browser/resources/ga... chrome/browser/resources/gaia_auth/saml_injected.js:179: * |passwordFields_|. Document fieldId?
Thanks for reviewing, suggested changes made in patch set 2.
lgtm
The CQ bit was checked by jayhlee@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053393003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by jayhlee@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053393003/20001
Message was sent while issue was closed.
Description was changed from ========== Track password field id so it can be used to improve uniqueness of passwordId BUG=618717 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== Track password field id so it can be used to improve uniqueness of passwordId BUG=618717 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
CQ bit was unchecked
Message was sent while issue was closed.
Description was changed from ========== Track password field id so it can be used to improve uniqueness of passwordId BUG=618717 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== Track password field id so it can be used to improve uniqueness of passwordId BUG=618717 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/8623bfce0e587884b73a85e0106059a46d598f2d Cr-Commit-Position: refs/heads/master@{#399266} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/8623bfce0e587884b73a85e0106059a46d598f2d Cr-Commit-Position: refs/heads/master@{#399266} |
