Machine-readable TurboFan compiler statistics

Machine-readable TurboFan compiler statistics

We'd like to track performance metrics in an automated way. This CL introduces
--turbo-stats-nvp which exposes --turbo-stats information in {"name"=value} pair
format.

BUG=

Committed: https://crrev.com/14732265690f533cf350290474b5026311522696
Cr-Commit-Position: refs/heads/master@{#36919}

[mvstanton, 2016-06-10 14:03:29]

mvstanton@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[mvstanton, 2016-06-10 14:03:29]

Hi Michael,
Here is a CL which adds "nvp" option to turbo stats. It doesn't print quite as
much information (only phase kinds, not stats on inner phases).
Thanks for the look,
--Mike

[Michael Starzinger, 2016-06-13 08:22:16]

LGTM with one suggestion.

https://codereview.chromium.org/2053383002/diff/1/src/compilation-statistics.cc
File src/compilation-statistics.cc (right):

https://codereview.chromium.org/2053383002/diff/1/src/compilation-statistics....
src/compilation-statistics.cc:130: if (!s.machine_output()) WriteHeader(os);
This hard-codes the printing format to be exclusively in one of the two formats.
We could instead parameterize the piping operator by using a struct. I was
thinking along the lines of ...

struct AsPrintableStatistics {
  const CompilationStatistics& s;
  const bool machine_output;
}

std::ostream& operator<<(std::ostream& os, const AsPrintableStatistics& s);

This way the CompilationStatistics data container is decoupled from the
configuration of how to print it. The piping operator could easily be called
twice in different configurations if need be. The call-sites control the
printing configuration directly.

[mvstanton, 2016-06-13 09:06:13]

Thanks for the suggestion! I've made use of this print/format struct as you
described. Uploadin'...

[mvstanton, 2016-06-13 09:06:26]

The CQ bit was checked by mvstanton@chromium.org

[mvstanton, 2016-06-13 09:06:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/2053383002/#ps20001
(title: "Code comments.")

[commit-bot: I haz the power, 2016-06-13 09:06:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2053383002/20001

[commit-bot: I haz the power, 2016-06-13 09:35:42]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-13 09:35:52]

Description was changed from

==========
Machine-readable TurboFan compiler statistics

We'd like to track performance metrics in an automated way. This CL introduces
--turbo-stats-nvp which exposes --turbo-stats information in {"name"=value} pair
format.

BUG=
==========

to

==========
Machine-readable TurboFan compiler statistics

We'd like to track performance metrics in an automated way. This CL introduces
--turbo-stats-nvp which exposes --turbo-stats information in {"name"=value} pair
format.

BUG=

Committed: https://crrev.com/14732265690f533cf350290474b5026311522696
Cr-Commit-Position: refs/heads/master@{#36919}
==========

[commit-bot: I haz the power, 2016-06-13 09:35:53]

Patchset 2 (id:??) landed as
https://crrev.com/14732265690f533cf350290474b5026311522696
Cr-Commit-Position: refs/heads/master@{#36919}