Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2053343003:
[Mac] Fix Issue to Exit Fullscreen (Closed)
Description[Mac] Fix Issue to Exit Fullscreen
Ensure that the browser exits fullscreen if toggleFullscreen was called
during the transition to fullscreen.
BUG=579934
Committed: https://crrev.com/104e5ad762f4d2fcf04a33ff8471d77d7b8678bb
Cr-Commit-Position: refs/heads/master@{#399506}
Patch Set 1 #
Total comments: 2
Patch Set 2 : #Patch Set 3 : rebased #
Messages
Total messages: 23 (9 generated)
Description was changed from ========== Comments lol Add flags Revert "Fixed async issue" This reverts commit 0d58c17858ed652798c9b8e5d2c55dd4ea52f2ae. Fixed async issue BUG= ========== to ========== [Mac] Fix Issue to Exit Fullscreen Ensure that the browser exits fullscreen if toggleFullscreen was called during the transition to fullscreen. BUG=579934 ==========
spqchan@chromium.org changed reviewers: + erikchen@chromium.org
PTAL
https://codereview.chromium.org/2053343003/diff/1/chrome/browser/ui/cocoa/bro... File chrome/browser/ui/cocoa/browser_window_controller_private.mm (right): https://codereview.chromium.org/2053343003/diff/1/chrome/browser/ui/cocoa/bro... chrome/browser/ui/cocoa/browser_window_controller_private.mm:765: if (shouldExitAfterEnteringFullscreen_) Don't you need to unset shouldExitAfterEnteringFullscreen_?
PTAL https://codereview.chromium.org/2053343003/diff/1/chrome/browser/ui/cocoa/bro... File chrome/browser/ui/cocoa/browser_window_controller_private.mm (right): https://codereview.chromium.org/2053343003/diff/1/chrome/browser/ui/cocoa/bro... chrome/browser/ui/cocoa/browser_window_controller_private.mm:765: if (shouldExitAfterEnteringFullscreen_) On 2016/06/10 20:54:23, erikchen wrote: > Don't you need to unset shouldExitAfterEnteringFullscreen_? Right
lgtm
+avi for OWNERS
spqchan@chromium.org changed reviewers: + ccameron@chromium.org
+ccameron for OWNERS
OWNERS lgtm
thanks!
The CQ bit was checked by spqchan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053343003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
The CQ bit was checked by spqchan@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from erikchen@chromium.org, ccameron@chromium.org Link to the patchset: https://codereview.chromium.org/2053343003/#ps40001 (title: "rebased")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053343003/40001
Message was sent while issue was closed.
Description was changed from ========== [Mac] Fix Issue to Exit Fullscreen Ensure that the browser exits fullscreen if toggleFullscreen was called during the transition to fullscreen. BUG=579934 ========== to ========== [Mac] Fix Issue to Exit Fullscreen Ensure that the browser exits fullscreen if toggleFullscreen was called during the transition to fullscreen. BUG=579934 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
CQ bit was unchecked
Message was sent while issue was closed.
Description was changed from ========== [Mac] Fix Issue to Exit Fullscreen Ensure that the browser exits fullscreen if toggleFullscreen was called during the transition to fullscreen. BUG=579934 ========== to ========== [Mac] Fix Issue to Exit Fullscreen Ensure that the browser exits fullscreen if toggleFullscreen was called during the transition to fullscreen. BUG=579934 Committed: https://crrev.com/104e5ad762f4d2fcf04a33ff8471d77d7b8678bb Cr-Commit-Position: refs/heads/master@{#399506} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/104e5ad762f4d2fcf04a33ff8471d77d7b8678bb Cr-Commit-Position: refs/heads/master@{#399506} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
