Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 2053343002: Add use counters for secure/insecure OpenSearch links and registerProtocolHandler (Closed)

Created:
4 years, 6 months ago by Mike West
Modified:
4 years, 6 months ago
Reviewers:
lgarron, Ilya Sherman
CC:
asvitkine+watch_chromium.org, blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, gyuyoung2, haraken, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add use counters for secure/insecure OpenSearch links and registerProtocolHandler BUG=617003 Committed: https://crrev.com/4116ecfd83c67233efa77ce355da4b3a53895141 Cr-Commit-Position: refs/heads/master@{#400148}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase. #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -0 lines) Patch
M third_party/WebKit/Source/core/dom/Document.cpp View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp View 2 chunks +4 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Mike West
lgarron@, mind taking a look? Sorry, this turned out to be trivial, so I just ...
4 years, 6 months ago (2016-06-10 11:46:06 UTC) #2
lgarron
https://codereview.chromium.org/2053343002/diff/1/third_party/WebKit/Source/core/dom/Document.cpp File third_party/WebKit/Source/core/dom/Document.cpp (right): https://codereview.chromium.org/2053343002/diff/1/third_party/WebKit/Source/core/dom/Document.cpp#newcode4562 third_party/WebKit/Source/core/dom/Document.cpp:4562: if (isSecureContext()) { Hmm, so there are 2 URLs ...
4 years, 6 months ago (2016-06-10 20:00:46 UTC) #3
Ilya Sherman
histograms.xml lgtm
4 years, 6 months ago (2016-06-10 21:11:36 UTC) #4
Mike West
On 2016/06/10 at 20:00:46, lgarron wrote: > https://codereview.chromium.org/2053343002/diff/1/third_party/WebKit/Source/core/dom/Document.cpp > File third_party/WebKit/Source/core/dom/Document.cpp (right): > > https://codereview.chromium.org/2053343002/diff/1/third_party/WebKit/Source/core/dom/Document.cpp#newcode4562 ...
4 years, 6 months ago (2016-06-12 14:58:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053343002/40001
4 years, 6 months ago (2016-06-14 08:28:47 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/238644)
4 years, 6 months ago (2016-06-14 09:48:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053343002/40001
4 years, 6 months ago (2016-06-16 09:25:20 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-16 14:07:45 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 14:08:58 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4116ecfd83c67233efa77ce355da4b3a53895141
Cr-Commit-Position: refs/heads/master@{#400148}

Powered by Google App Engine
This is Rietveld 408576698