Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2053333002: Fix race when HTMLMediaElement.play() is called just after pause(). (Closed)

Created:
4 years, 6 months ago by mlamouri (slow - plz ping)
Modified:
4 years, 6 months ago
Reviewers:
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, mlamouri+watch-blink_chromium.org, posciak+watch_chromium.org, nessy, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Fix race when HTMLMediaElement.play() is called just after pause(). The consequence is that the Promise returned by play() is rejected by the task created by pause(). The fix is to associate the tasks with a list of promises. BUG=593273 TBR=avayvod@chromium.org Review-Url: https://codereview.chromium.org/1865933002 Cr-Commit-Position: refs/heads/master@{#398370} (cherry picked from commit 3a82d82079ca79cddd932eb77f924db5428885b9) Committed: https://chromium.googlesource.com/chromium/src/+/b62b49b650018c1367069a6c8e2a049e998fc4d9

Patch Set 1 #

Messages

Total messages: 3 (2 generated)
mlamouri (slow - plz ping)
4 years, 6 months ago (2016-06-10 10:36:53 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b62b49b650018c1367069a6c8e2a049e998fc4d9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698