Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 205333004: Deferred image decoding to handle broken GIFs (Closed)

Created:
6 years, 9 months ago by Alpha Left Google
Modified:
6 years, 9 months ago
Reviewers:
Stephen White
CC:
blink-reviews, jamesr, krit, dsinclair, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Visibility:
Public.

Description

Deferred image decoding to handle broken GIFs With some broken animated images the decoder could report a smaller frame number as more data is received. We should handle this edge case by early out. The animation sequence might not be correct. That's okay because it's a broken file. BUG=352421 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169698

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M Source/platform/graphics/DeferredImageDecoder.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/platform/graphics/DeferredImageDecoderTest.cpp View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Alpha Left Google
6 years, 9 months ago (2014-03-19 23:11:41 UTC) #1
Alpha Left Google
ping. This needs to merge to m34.
6 years, 9 months ago (2014-03-20 20:47:12 UTC) #2
Stephen White
LGTM
6 years, 9 months ago (2014-03-20 20:51:56 UTC) #3
Alpha Left Google
The CQ bit was checked by hclam@chromium.org
6 years, 9 months ago (2014-03-20 20:52:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/205333004/1
6 years, 9 months ago (2014-03-20 20:52:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/205333004/1
6 years, 9 months ago (2014-03-20 21:56:17 UTC) #6
commit-bot: I haz the power
6 years, 9 months ago (2014-03-20 22:00:04 UTC) #7
Message was sent while issue was closed.
Change committed as 169698

Powered by Google App Engine
This is Rietveld 408576698