Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2053313002: [telemetry] Expose log file contents in telemetry.internal.browser.Browser (Closed)

Created:
4 years, 6 months ago by petrcermak
Modified:
4 years, 6 months ago
Reviewers:
nednguyen
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Base URL:
git@github.com:catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[telemetry] Expose log file contents in telemetry.internal.browser.Browser This allows users of the Browser class to get the contents of the browser log (e.g. in the case of a test failure). BUG=chromium:616483, chromium:612779 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/e37097a1cbf91eedb1dbf881bedd0fa946e593a8

Patch Set 1 #

Patch Set 2 : Change decorator name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -23 lines) Patch
M telemetry/telemetry/internal/backends/browser_backend.py View 1 chunk +4 lines, -0 lines 0 comments Download
M telemetry/telemetry/internal/backends/browser_backend_unittest.py View 2 chunks +32 lines, -20 lines 0 comments Download
M telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend_unittest.py View 1 4 chunks +10 lines, -3 lines 0 comments Download
M telemetry/telemetry/internal/browser/browser.py View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
petrcermak
PTAL. Thanks, Petr
4 years, 6 months ago (2016-06-10 10:31:40 UTC) #3
nednguyen
lgtm
4 years, 6 months ago (2016-06-10 12:53:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053313002/20001
4 years, 6 months ago (2016-06-10 12:54:32 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 13:18:40 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698