Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 20533: Experimental: fix a frame-height issue with eval on ARM. (Closed)

Created:
11 years, 10 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Experimental: fix a frame-height issue with eval on ARM. Also, added frame-height assertions for ARM to the code generator's Visit member functions. Committed: http://code.google.com/p/v8/source/detail?r=1328

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+227 lines, -55 lines) Patch
M src/codegen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/codegen-arm.cc View 1 42 chunks +226 lines, -54 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
Kevin Millikin (Chromium)
11 years, 10 months ago (2009-02-20 09:52:06 UTC) #1
Kevin Millikin (Chromium)
Now with added assertions. All over the place.
11 years, 10 months ago (2009-02-20 12:46:03 UTC) #2
William Hesse
LGTM. http://codereview.chromium.org/20533/diff/4/1003 File src/codegen-arm.cc (right): http://codereview.chromium.org/20533/diff/4/1003#newcode1573 Line 1573: ASSERT(!has_valid_frame() || frame_->height() == original_height); How could ...
11 years, 10 months ago (2009-02-20 13:06:20 UTC) #3
Kevin Millikin (Chromium)
http://codereview.chromium.org/20533/diff/4/1003 File src/codegen-arm.cc (right): http://codereview.chromium.org/20533/diff/4/1003#newcode1573 Line 1573: ASSERT(!has_valid_frame() || frame_->height() == original_height); On 2009/02/20 13:06:20, ...
11 years, 10 months ago (2009-02-20 13:12:48 UTC) #4
Mads Ager (chromium)
11 years, 10 months ago (2009-02-20 13:28:17 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698