Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Unified Diff: third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp

Issue 2053273002: Remove WorkerBackingThread::scriptCount (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThread.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp
diff --git a/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp b/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp
index 947cf8030a192a1ee22d7d28e25facc6f070d904..1b3c0d8340d2e7efbcb570e6cce64f6b5087ec2d 100644
--- a/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp
+++ b/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp
@@ -106,7 +106,6 @@ public:
void TearDown() override
{
m_page.reset();
- CompositorWorkerThread::terminateExecution();
CompositorWorkerThread::clearSharedBackingThread();
}
@@ -142,7 +141,6 @@ public:
private:
void executeScriptInWorker(WorkerThread* worker, WaitableEvent* waitEvent)
{
- EXPECT_GT(worker->workerBackingThread().workerScriptCount(), 0u);
WorkerOrWorkletScriptController* scriptController = worker->workerGlobalScope()->scriptController();
bool evaluateResult = scriptController->evaluate(ScriptSourceCode("var counter = 0; ++counter;"));
ASSERT_UNUSED(evaluateResult, evaluateResult);
@@ -174,7 +172,9 @@ TEST_F(CompositorWorkerThreadTest, CreateSecondAndTerminateFirst)
// Create the second worker and immediately destroy the first worker.
OwnPtr<CompositorWorkerThread> secondWorker = createCompositorWorker();
- firstWorker->terminateAndWait();
+ // We don't use terminateAndWait here to avoid forcible termination.
+ firstWorker->terminate();
+ firstWorker->waitForShutdownForTesting();
// Wait until the second worker is initialized. Verify that the second worker is using the same
// thread and Isolate as the first worker.
@@ -196,21 +196,18 @@ TEST_F(CompositorWorkerThreadTest, TerminateFirstAndCreateSecond)
{
// Create the first worker, wait until it is initialized, and terminate it.
OwnPtr<CompositorWorkerThread> compositorWorker = createCompositorWorker();
- WorkerBackingThread* workerBackingThread = &compositorWorker->workerBackingThread();
WebThreadSupportingGC* firstThread = &compositorWorker->workerBackingThread().backingThread();
checkWorkerCanExecuteScript(compositorWorker.get());
- ASSERT_EQ(2u, workerBackingThread->workerScriptCount());
- compositorWorker->terminateAndWait();
-
- ASSERT_EQ(1u, workerBackingThread->workerScriptCount());
+ // We don't use terminateAndWait here to avoid forcible termination.
+ compositorWorker->terminate();
+ compositorWorker->waitForShutdownForTesting();
// Create the second worker. The backing thread is same.
compositorWorker = createCompositorWorker();
WebThreadSupportingGC* secondThread = &compositorWorker->workerBackingThread().backingThread();
EXPECT_EQ(firstThread, secondThread);
checkWorkerCanExecuteScript(compositorWorker.get());
- ASSERT_EQ(2u, workerBackingThread->workerScriptCount());
compositorWorker->terminateAndWait();
}
@@ -225,7 +222,6 @@ TEST_F(CompositorWorkerThreadTest, CreatingSecondDuringTerminationOfFirst)
// Request termination of the first worker and create the second worker
// as soon as possible.
- EXPECT_EQ(2u, firstWorker->workerBackingThread().workerScriptCount());
firstWorker->terminate();
// We don't wait for its termination.
// Note: We rely on the assumption that the termination steps don't run
« no previous file with comments | « third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThread.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698