Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 2053253002: Support a ui::test::EventGenerator constructed with a single argument on Mac (Closed)

Created:
4 years, 6 months ago by tapted
Modified:
4 years, 6 months ago
Reviewers:
sadrul
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support a ui::test::EventGenerator constructed with a single argument on Mac EventGeneratorDelegateMac::SetContext(..) ignores |root_window|. If that was all that's provided, assume it's the active window. This fixes all the Mac views_unittests regressions from r398705. BUG=618880 Committed: https://crrev.com/d688b3e828f5eb8cec391d0126e362cbf1eb48db Cr-Commit-Position: refs/heads/master@{#399409}

Patch Set 1 #

Patch Set 2 : Update EventGenerator comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M ui/events/test/event_generator.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M ui/views/test/event_generator_delegate_mac.mm View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
tapted
Hi sadrul, please take a look
4 years, 6 months ago (2016-06-10 06:46:48 UTC) #3
sadrul
lgtm Thanks! Are these tests not run on the regular/default set of buildbots/trybots?
4 years, 6 months ago (2016-06-10 13:44:43 UTC) #4
tapted
On 2016/06/10 13:44:43, sadrul wrote: > lgtm Thanks! Are these tests not run on the ...
4 years, 6 months ago (2016-06-13 05:44:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053253002/20001
4 years, 6 months ago (2016-06-13 05:45:16 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-13 06:29:19 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 06:30:50 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d688b3e828f5eb8cec391d0126e362cbf1eb48db
Cr-Commit-Position: refs/heads/master@{#399409}

Powered by Google App Engine
This is Rietveld 408576698