Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2236)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 2053233002: Make sure FrameScheduler is cleared when LocalFrame::detach() finishes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 90b315142fcc9d574e24892217ac080802a8d9ef..893741919788fa153a89c79598e759c468379fcb 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -1188,7 +1188,7 @@ void RenderFrameImpl::Initialize() {
void RenderFrameImpl::InitializeBlameContext(RenderFrameImpl* parent_frame) {
DCHECK(!blame_context_);
- blame_context_ = new FrameBlameContext(this, parent_frame);
+ blame_context_ = base::WrapUnique(new FrameBlameContext(this, parent_frame));
blame_context_->Initialize();
}
@@ -2638,7 +2638,7 @@ blink::WebCookieJar* RenderFrameImpl::cookieJar() {
blink::BlameContext* RenderFrameImpl::frameBlameContext() {
DCHECK(blame_context_);
- return blame_context_;
+ return blame_context_.get();
Primiano Tucci (use gerrit) 2016/06/10 07:50:35 how do you know that this is the right thread (The
Xiaocheng 2016/06/10 08:07:08 blame_context_ is an std::unique_ptr so we are saf
}
blink::WebServiceWorkerProvider*

Powered by Google App Engine
This is Rietveld 408576698