components/scheduler/renderer/web_frame_scheduler_impl.h - Issue 2053233002: Make sure FrameScheduler is cleared when LocalFrame::detach() finishes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/scheduler/renderer/web_frame_scheduler_impl.h

Issue 2053233002: Make sure FrameScheduler is cleared when LocalFrame::detach() finishes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/scheduler/child/single_thread_idle_task_runner.cc ('K') | « components/scheduler/child/single_thread_idle_task_runner.cc ('k') | components/scheduler/renderer/web_frame_scheduler_impl.cc » ('j') | content/renderer/render_frame_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/scheduler/renderer/web_frame_scheduler_impl.h

diff --git a/components/scheduler/renderer/web_frame_scheduler_impl.h b/components/scheduler/renderer/web_frame_scheduler_impl.h

index 25a18518660c6425e9f01077f547380fe8832e5b..dddbd4d6261a740aec85d8470b66ad1c3baed6c4 100644

--- a/components/scheduler/renderer/web_frame_scheduler_impl.h

+++ b/components/scheduler/renderer/web_frame_scheduler_impl.h

@@ -57,7 +57,7 @@ class SCHEDULER_EXPORT WebFrameSchedulerImpl : public blink::WebFrameScheduler {

std::unique_ptr<WebTaskRunnerImpl> timer_web_task_runner_;

RendererSchedulerImpl* renderer_scheduler_; // NOT OWNED

WebViewSchedulerImpl* parent_web_view_scheduler_; // NOT OWNED

- base::trace_event::BlameContext* blame_context_; // NOT OWNED

+ base::WeakPtr<base::trace_event::BlameContext> blame_context_;

TaskQueue::PumpPolicy virtual_time_pump_policy_;

bool frame_visible_;

bool page_visible_;