components/scheduler/base/task_queue_impl.h - Issue 2053233002: Make sure FrameScheduler is cleared when LocalFrame::detach() finishes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/scheduler/base/task_queue_impl.h

Issue 2053233002: Make sure FrameScheduler is cleared when LocalFrame::detach() finishes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « base/trace_event/blame_context.h ('k') | components/scheduler/base/task_queue_impl.cc » ('j') | components/scheduler/child/single_thread_idle_task_runner.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/scheduler/base/task_queue_impl.h

diff --git a/components/scheduler/base/task_queue_impl.h b/components/scheduler/base/task_queue_impl.h

index 69fd02e854927f58d4b7ac2b09fa6d1217134b53..b0d16bb134bec524c3ee152c5bfb6238ffb118fa 100644

--- a/components/scheduler/base/task_queue_impl.h

+++ b/components/scheduler/base/task_queue_impl.h

@@ -205,7 +205,7 @@ class SCHEDULER_EXPORT TaskQueueImpl final : public TaskQueue {

base::ObserverList<base::MessageLoop::TaskObserver> task_observers;

size_t set_index;

bool is_enabled;

- base::trace_event::BlameContext* blame_context; // Not owned.

+ base::WeakPtr<base::trace_event::BlameContext> blame_context;

};

~TaskQueueImpl() override;