Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: components/scheduler/renderer/web_frame_scheduler_impl.cc

Issue 2053233002: Make sure FrameScheduler is cleared when LocalFrame::detach() finishes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/scheduler/renderer/web_frame_scheduler_impl.h" 5 #include "components/scheduler/renderer/web_frame_scheduler_impl.h"
6 6
7 #include "base/trace_event/blame_context.h" 7 #include "base/trace_event/blame_context.h"
8 #include "components/scheduler/base/real_time_domain.h" 8 #include "components/scheduler/base/real_time_domain.h"
9 #include "components/scheduler/base/virtual_time_domain.h" 9 #include "components/scheduler/base/virtual_time_domain.h"
10 #include "components/scheduler/child/web_task_runner_impl.h" 10 #include "components/scheduler/child/web_task_runner_impl.h"
11 #include "components/scheduler/renderer/auto_advancing_virtual_time_domain.h" 11 #include "components/scheduler/renderer/auto_advancing_virtual_time_domain.h"
12 #include "components/scheduler/renderer/renderer_scheduler_impl.h" 12 #include "components/scheduler/renderer/renderer_scheduler_impl.h"
13 #include "components/scheduler/renderer/web_view_scheduler_impl.h" 13 #include "components/scheduler/renderer/web_view_scheduler_impl.h"
14 #include "third_party/WebKit/public/platform/BlameContext.h" 14 #include "third_party/WebKit/public/platform/BlameContext.h"
15 #include "third_party/WebKit/public/platform/WebString.h" 15 #include "third_party/WebKit/public/platform/WebString.h"
16 16
17 namespace scheduler { 17 namespace scheduler {
18 18
19 WebFrameSchedulerImpl::WebFrameSchedulerImpl( 19 WebFrameSchedulerImpl::WebFrameSchedulerImpl(
20 RendererSchedulerImpl* renderer_scheduler, 20 RendererSchedulerImpl* renderer_scheduler,
21 WebViewSchedulerImpl* parent_web_view_scheduler, 21 WebViewSchedulerImpl* parent_web_view_scheduler,
22 base::trace_event::BlameContext* blame_context) 22 base::trace_event::BlameContext* blame_context)
23 : renderer_scheduler_(renderer_scheduler), 23 : renderer_scheduler_(renderer_scheduler),
24 parent_web_view_scheduler_(parent_web_view_scheduler), 24 parent_web_view_scheduler_(parent_web_view_scheduler),
25 blame_context_(blame_context), 25 blame_context_(blame_context ? blame_context->weak_ptr() : nullptr),
26 frame_visible_(true), 26 frame_visible_(true),
27 page_visible_(true) {} 27 page_visible_(true) {}
28 28
29 WebFrameSchedulerImpl::~WebFrameSchedulerImpl() { 29 WebFrameSchedulerImpl::~WebFrameSchedulerImpl() {
30 if (loading_task_queue_.get()) { 30 if (loading_task_queue_.get()) {
31 loading_task_queue_->UnregisterTaskQueue(); 31 loading_task_queue_->UnregisterTaskQueue();
32 loading_task_queue_->SetBlameContext(nullptr); 32 loading_task_queue_->SetBlameContext(nullptr);
33 } 33 }
34 34
35 if (timer_task_queue_.get()) { 35 if (timer_task_queue_.get()) {
(...skipping 12 matching lines...) Expand all
48 void WebFrameSchedulerImpl::setFrameVisible(bool frame_visible) { 48 void WebFrameSchedulerImpl::setFrameVisible(bool frame_visible) {
49 frame_visible_ = frame_visible; 49 frame_visible_ = frame_visible;
50 // TODO(alexclarke): Do something with this flag. 50 // TODO(alexclarke): Do something with this flag.
51 } 51 }
52 52
53 blink::WebTaskRunner* WebFrameSchedulerImpl::loadingTaskRunner() { 53 blink::WebTaskRunner* WebFrameSchedulerImpl::loadingTaskRunner() {
54 DCHECK(parent_web_view_scheduler_); 54 DCHECK(parent_web_view_scheduler_);
55 if (!loading_web_task_runner_) { 55 if (!loading_web_task_runner_) {
56 loading_task_queue_ = 56 loading_task_queue_ =
57 renderer_scheduler_->NewLoadingTaskRunner("frame_loading_tq"); 57 renderer_scheduler_->NewLoadingTaskRunner("frame_loading_tq");
58 loading_task_queue_->SetBlameContext(blame_context_); 58 loading_task_queue_->SetBlameContext(blame_context_.get());
59 if (parent_web_view_scheduler_->virtual_time_domain()) { 59 if (parent_web_view_scheduler_->virtual_time_domain()) {
60 loading_task_queue_->SetTimeDomain( 60 loading_task_queue_->SetTimeDomain(
61 parent_web_view_scheduler_->virtual_time_domain()); 61 parent_web_view_scheduler_->virtual_time_domain());
62 } 62 }
63 loading_web_task_runner_.reset(new WebTaskRunnerImpl(loading_task_queue_)); 63 loading_web_task_runner_.reset(new WebTaskRunnerImpl(loading_task_queue_));
64 } 64 }
65 return loading_web_task_runner_.get(); 65 return loading_web_task_runner_.get();
66 } 66 }
67 67
68 blink::WebTaskRunner* WebFrameSchedulerImpl::timerTaskRunner() { 68 blink::WebTaskRunner* WebFrameSchedulerImpl::timerTaskRunner() {
69 DCHECK(parent_web_view_scheduler_); 69 DCHECK(parent_web_view_scheduler_);
70 if (!timer_web_task_runner_) { 70 if (!timer_web_task_runner_) {
71 timer_task_queue_ = 71 timer_task_queue_ =
72 renderer_scheduler_->NewTimerTaskRunner("frame_timer_tq"); 72 renderer_scheduler_->NewTimerTaskRunner("frame_timer_tq");
73 timer_task_queue_->SetBlameContext(blame_context_); 73 timer_task_queue_->SetBlameContext(blame_context_.get());
74 if (parent_web_view_scheduler_->virtual_time_domain()) { 74 if (parent_web_view_scheduler_->virtual_time_domain()) {
75 timer_task_queue_->SetTimeDomain( 75 timer_task_queue_->SetTimeDomain(
76 parent_web_view_scheduler_->virtual_time_domain()); 76 parent_web_view_scheduler_->virtual_time_domain());
77 } else if (!page_visible_) { 77 } else if (!page_visible_) {
78 renderer_scheduler_->throttling_helper()->IncreaseThrottleRefCount( 78 renderer_scheduler_->throttling_helper()->IncreaseThrottleRefCount(
79 timer_task_queue_.get()); 79 timer_task_queue_.get());
80 } 80 }
81 timer_web_task_runner_.reset(new WebTaskRunnerImpl(timer_task_queue_)); 81 timer_web_task_runner_.reset(new WebTaskRunnerImpl(timer_task_queue_));
82 } 82 }
83 return timer_web_task_runner_.get(); 83 return timer_web_task_runner_.get();
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
115 parent_web_view_scheduler_->virtual_time_domain()); 115 parent_web_view_scheduler_->virtual_time_domain());
116 } 116 }
117 117
118 if (loading_task_queue_) { 118 if (loading_task_queue_) {
119 loading_task_queue_->SetTimeDomain( 119 loading_task_queue_->SetTimeDomain(
120 parent_web_view_scheduler_->virtual_time_domain()); 120 parent_web_view_scheduler_->virtual_time_domain());
121 } 121 }
122 } 122 }
123 123
124 } // namespace scheduler 124 } // namespace scheduler
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698