Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Unified Diff: third_party/WebKit/Source/web/tests/WebViewTest.cpp

Issue 2053213002: Don't suspend caret blinking on long press (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixed unit test Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/input/KeyboardEventManager.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/tests/WebViewTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/WebViewTest.cpp b/third_party/WebKit/Source/web/tests/WebViewTest.cpp
index 905d7365cc9cec5397c4eedc2e66a98e6d0254fb..1ca5a99d55f1173ee8ead38a93593e6f03211f47 100644
--- a/third_party/WebKit/Source/web/tests/WebViewTest.cpp
+++ b/third_party/WebKit/Source/web/tests/WebViewTest.cpp
@@ -1787,7 +1787,7 @@ TEST_F(WebViewTest, LongPressImageTextarea)
EXPECT_EQ(1UL, length);
}
-TEST_F(WebViewTest, BlinkCaretOnTypingAfterLongPress)
+TEST_F(WebViewTest, BlinkCaretAfterLongPress)
{
URLTestHelpers::registerMockedURLFromBaseURL(WebString::fromUTF8(m_baseURL.c_str()), WebString::fromUTF8("blink_caret_on_typing_after_long_press.html"));
@@ -1800,13 +1800,6 @@ TEST_F(WebViewTest, BlinkCaretOnTypingAfterLongPress)
WebLocalFrameImpl* mainFrame = toWebLocalFrameImpl(webView->mainFrame());
EXPECT_TRUE(tapElementById(WebInputEvent::GestureLongPress, target));
- EXPECT_TRUE(mainFrame->frame()->selection().isCaretBlinkingSuspended());
-
- WebKeyboardEvent keyEvent;
- keyEvent.type = WebInputEvent::RawKeyDown;
- webView->handleInputEvent(keyEvent);
- keyEvent.type = WebInputEvent::KeyUp;
- webView->handleInputEvent(keyEvent);
EXPECT_FALSE(mainFrame->frame()->selection().isCaretBlinkingSuspended());
}
« no previous file with comments | « third_party/WebKit/Source/core/input/KeyboardEventManager.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698