Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(703)

Unified Diff: third_party/WebKit/Source/core/input/EventHandler.cpp

Issue 2053213002: Don't suspend caret blinking on long press (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixed unit test Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/input/KeyboardEventManager.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/input/EventHandler.cpp
diff --git a/third_party/WebKit/Source/core/input/EventHandler.cpp b/third_party/WebKit/Source/core/input/EventHandler.cpp
index 39b426486a0639eba217e8c0ba1b7182be1cd34e..919c42388cb524c01726b633a4b8ecd5c2f695b3 100644
--- a/third_party/WebKit/Source/core/input/EventHandler.cpp
+++ b/third_party/WebKit/Source/core/input/EventHandler.cpp
@@ -853,7 +853,8 @@ WebInputEventResult EventHandler::handleMousePressEvent(const PlatformMouseEvent
m_clickCount = mouseEvent.clickCount();
m_clickNode = mev.innerNode()->isTextNode() ? FlatTreeTraversal::parent(*mev.innerNode()) : mev.innerNode();
- m_frame->selection().setCaretBlinkingSuspended(true);
+ if (!mouseEvent.fromTouch())
+ m_frame->selection().setCaretBlinkingSuspended(true);
WebInputEventResult eventResult = updatePointerTargetAndDispatchEvents(EventTypeNames::mousedown, mev.innerNode(), m_clickCount, mev.event());
@@ -1108,7 +1109,8 @@ WebInputEventResult EventHandler::handleMouseReleaseEvent(const PlatformMouseEve
if (mouseEvent.button() == NoButton)
return WebInputEventResult::HandledSuppressed;
- m_frame->selection().setCaretBlinkingSuspended(false);
+ if (!mouseEvent.fromTouch())
+ m_frame->selection().setCaretBlinkingSuspended(false);
OwnPtr<UserGestureIndicator> gestureIndicator;
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/input/KeyboardEventManager.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698