Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Unified Diff: components/offline_pages/background/save_page_request_unittest.cc

Issue 2053163002: [Offline pages] Adding persistent request queue based on SQLite (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebasing Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/save_page_request_unittest.cc
diff --git a/components/offline_pages/background/save_page_request_unittest.cc b/components/offline_pages/background/save_page_request_unittest.cc
index e6d58bfb5400faf3179db25a6c48a0028c55d871..c4d1561473cfeece08d19b2767d3345d40830444 100644
--- a/components/offline_pages/background/save_page_request_unittest.cc
+++ b/components/offline_pages/background/save_page_request_unittest.cc
@@ -81,7 +81,8 @@ TEST_F(SavePageRequestTest, StartAndCompleteRequest) {
ASSERT_EQ(SavePageRequest::Status::STARTED, request.GetStatus(start_time));
- request.MarkAttemptCompleted();
+ base::Time completion_time = base::Time::Now();
+ request.MarkAttemptCompleted(completion_time);
// Again, most things don't change about the request.
ASSERT_EQ(kRequestId, request.request_id());
@@ -89,6 +90,7 @@ TEST_F(SavePageRequestTest, StartAndCompleteRequest) {
ASSERT_EQ(kClientId, request.client_id());
ASSERT_EQ(creation_time, request.creation_time());
ASSERT_EQ(activation_time, request.activation_time());
+ ASSERT_EQ(completion_time, request.last_attempt_time());
// Last attempt time and status will. Attempt count also unchanged.
ASSERT_EQ(base::Time(), request.last_attempt_time());

Powered by Google App Engine
This is Rietveld 408576698