components/offline_pages/background/request_queue_in_memory_store.cc - Issue 2053163002: [Offline pages] Adding persistent request queue based on SQLite

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/background/request_queue_in_memory_store.cc

Issue 2053163002: [Offline pages] Adding persistent request queue based on SQLite (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebasing Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/components_tests.gyp ('K') | « components/offline_pages/background/BUILD.gn ('k') | components/offline_pages/background/request_queue_in_memory_store_unittest.cc » ('j') | components/offline_pages/background/request_queue_in_memory_store_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/offline_pages/background/request_queue_in_memory_store.cc

diff --git a/components/offline_pages/background/request_queue_in_memory_store.cc b/components/offline_pages/background/request_queue_in_memory_store.cc

index 83f59f4b02ef06ebe2234b41adda9bb47f266dca..bca98c92c70c48370e853e24b09e57edebf187da 100644

--- a/components/offline_pages/background/request_queue_in_memory_store.cc

+++ b/components/offline_pages/background/request_queue_in_memory_store.cc

@@ -51,8 +51,6 @@ void RequestQueueInMemoryStore::RemoveRequests(

if (iter != requests_.end()) {

requests_.erase(iter);

++count;

- } else {

- result = false;

}