components/offline_pages/background/request_queue.cc - Issue 2053163002: [Offline pages] Adding persistent request queue based on SQLite

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/background/request_queue.cc

Issue 2053163002: [Offline pages] Adding persistent request queue based on SQLite (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixing code comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/offline_pages/background/DEPS ('k') | components/offline_pages/background/request_queue_in_memory_store.cc » ('j') | components/offline_pages/background/request_queue_store_sql.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/offline_pages/background/request_queue.cc

diff --git a/components/offline_pages/background/request_queue.cc b/components/offline_pages/background/request_queue.cc

index 7626601a6a8cd80849debdcf021f4cf5db1c654e..5fbd0baeda553a858c2a6abfb333574c695aef68 100644

--- a/components/offline_pages/background/request_queue.cc

+++ b/components/offline_pages/background/request_queue.cc

@@ -32,7 +32,7 @@ void AddRequestDone(const RequestQueue::AddRequestCallback& callback,

const SavePageRequest& request,

RequestQueueStore::UpdateStatus status) {

RequestQueue::AddRequestResult result =

- (status == RequestQueueStore::UpdateStatus::ADDED)

+ (status == RequestQueueStore::UpdateStatus::UPDATED)

? RequestQueue::AddRequestResult::SUCCESS

: RequestQueue::AddRequestResult::STORE_FAILURE;

callback.Run(result, request);