components/offline_pages/background/BUILD.gn - Issue 2053163002: [Offline pages] Adding persistent request queue based on SQLite

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/background/BUILD.gn

Issue 2053163002: [Offline pages] Adding persistent request queue based on SQLite (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing code review feedback from petewil Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/offline_pages.gypi ('k') | components/offline_pages/background/DEPS » ('j') | components/offline_pages/background/request_queue_store_sql.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/offline_pages/background/BUILD.gn

diff --git a/components/offline_pages/background/BUILD.gn b/components/offline_pages/background/BUILD.gn

index b0b12ca1630653bc8e18c5ca276b21cc6be16a21..4c21be2e79dcaaecc0781790d63e732e3c2b0ad4 100644

--- a/components/offline_pages/background/BUILD.gn

+++ b/components/offline_pages/background/BUILD.gn

@@ -21,6 +21,8 @@ static_library("background_offliner") {

"request_queue_in_memory_store.cc",

"request_queue_in_memory_store.h",

"request_queue_store.h",

+ "request_queue_store_sql.cc",

+ "request_queue_store_sql.h",

"save_page_request.cc",

"save_page_request.h",

"scheduler.h",

@@ -31,6 +33,7 @@ static_library("background_offliner") {

"//components/keyed_service/core",

"//components/offline_pages:offline_pages",

"//net",

+ "//sql:sql",

"//url",

]

}

@@ -40,7 +43,7 @@ source_set("unit_tests") {

sources = [

"request_coordinator_unittest.cc",

"request_picker_unittest.cc",

- "request_queue_in_memory_store_unittest.cc",

+ "request_queue_store_unittest.cc",

"request_queue_unittest.cc",

"save_page_request_unittest.cc",

]