[Offline pages] Adding persistent request queue based on SQLite

components/components_tests.gyp

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     # This turns on e.g. the filename-based detection of which
     # platforms to include source files on (e.g. files ending in
     # _mac.h or _mac.cc are only compiled on MacOSX).
     'chromium_code': 1,
@@ skipping 64 matching lines @@
       'bookmarks/browser/bookmark_expanded_state_tracker_unittest.cc',
       'bookmarks/browser/bookmark_index_unittest.cc',
       'bookmarks/browser/bookmark_model_unittest.cc',
       'bookmarks/browser/bookmark_utils_unittest.cc',
       'bookmarks/managed/managed_bookmarks_tracker_unittest.cc',
     ],
     'browser_sync_unittest_sources': [
       'browser_sync/browser/profile_sync_service_autofill_unittest.cc',
       'browser_sync/browser/profile_sync_service_bookmark_unittest.cc',
       'browser_sync/browser/profile_sync_service_startup_unittest.cc',
+      'browser_sync/browser/profile_sync_service_typed_url_unittest.cc',
       'browser_sync/browser/profile_sync_service_unittest.cc',
-      'browser_sync/browser/profile_sync_service_typed_url_unittest.cc',
     ],
     'browser_watcher_unittest_sources': [
       'browser_watcher/endsession_watcher_window_win_unittest.cc',
       'browser_watcher/exit_code_watcher_win_unittest.cc',
       'browser_watcher/exit_funnel_win_unittest.cc',
       'browser_watcher/watcher_client_win_unittest.cc',
       'browser_watcher/watcher_metrics_provider_win_unittest.cc',
       'browser_watcher/window_hang_monitor_win_unittest.cc',
     ],
     'browsing_data_ui_unittest_sources': [
@@ skipping 267 matching lines @@
       'memory_pressure/filtered_memory_pressure_calculator_unittest.cc',
       'memory_pressure/memory_pressure_monitor_unittest.cc',
       'memory_pressure/memory_pressure_stats_collector_unittest.cc',
       'memory_pressure/test_memory_pressure_calculator.cc',
       'memory_pressure/test_memory_pressure_calculator.h',
     ],
     'metrics_unittest_sources': [
       'metrics/call_stack_profile_metrics_provider_unittest.cc',
       'metrics/cloned_install_detector_unittest.cc',
       'metrics/daily_event_unittest.cc',
+      'metrics/data_use_tracker_unittest.cc',
       'metrics/drive_metrics_provider_unittest.cc',
       'metrics/file_metrics_provider_unittest.cc',
       'metrics/histogram_encoder_unittest.cc',
       'metrics/machine_id_provider_win_unittest.cc',
-      'metrics/data_use_tracker_unittest.cc',
       'metrics/metrics_log_manager_unittest.cc',
       'metrics/metrics_log_unittest.cc',
       'metrics/metrics_reporting_scheduler_unittest.cc',
       'metrics/metrics_service_unittest.cc',
       'metrics/metrics_state_manager_unittest.cc',
       'metrics/net/net_metrics_log_uploader_unittest.cc',
       'metrics/persisted_logs_unittest.cc',
       'metrics/profiler/profiler_metrics_provider_unittest.cc',
       'metrics/profiler/tracking_synchronizer_unittest.cc',
       'metrics/stability_metrics_helper_unittest.cc',
       'metrics/ui/screen_info_metrics_provider_unittest.cc',
     ],
     'metrics_leak_detector_unittest_sources': [
       'metrics/leak_detector/call_stack_manager_unittest.cc',
       'metrics/leak_detector/call_stack_table_unittest.cc',
       'metrics/leak_detector/leak_analyzer_unittest.cc',
+      'metrics/leak_detector/leak_detector_impl_unittest.cc',
       'metrics/leak_detector/leak_detector_unittest.cc',
-      'metrics/leak_detector/leak_detector_impl_unittest.cc',
       'metrics/leak_detector/ranked_set_unittest.cc',
     ],
     'mime_util_unittest_sources': [
       'mime_util/mime_util_unittest.cc',
     ],
     'nacl_unittest_sources': [
       'nacl/browser/nacl_file_host_unittest.cc',
       'nacl/browser/nacl_process_host_unittest.cc',
       'nacl/browser/nacl_validation_cache_unittest.cc',
       'nacl/browser/pnacl_host_unittest.cc',
@@ skipping 18 matching lines @@
       'ntp_snippets/ntp_snippets_database_unittest.cc',
       'ntp_snippets/ntp_snippets_fetcher_unittest.cc',
       'ntp_snippets/ntp_snippets_service_unittest.cc',
     ],
     'ntp_tiles_unittest_sources': [
       'ntp_tiles/most_visited_sites_unittest.cc',
     ],
     'offline_pages_background_unittest_sources': [
       'offline_pages/background/request_coordinator_unittest.cc',
       'offline_pages/background/request_picker_unittest.cc',
-      'offline_pages/background/request_queue_in_memory_store_unittest.cc',
+      'offline_pages/background/request_queue_store_unittest.cc',

[Pete Williamson, 2016/06/14 21:54:45]

Should we keep the in memory store unittest?  The memory store sure is handy for
other unit tests. 

[fgorski, 2016/06/14 22:38:05]

we are, we are converting the test to a typed test to make sure both stores work
the same way.

       'offline_pages/background/request_queue_unittest.cc',
       'offline_pages/background/save_page_request_unittest.cc',
     ],
     'offline_pages_unittest_sources': [
       'offline_pages/archive_manager_unittest.cc',
       'offline_pages/client_policy_controller_unittest.cc',
       'offline_pages/offline_page_metadata_store_impl_unittest.cc',
       'offline_pages/offline_page_model_impl_unittest.cc',
       'offline_pages/offline_page_storage_manager_unittest.cc',
       'offline_pages/snapshot_controller_unittest.cc',
@@ skipping 54 matching lines @@
       'password_manager/core/browser/affiliation_fetch_throttler_unittest.cc',
       'password_manager/core/browser/affiliation_fetcher_unittest.cc',
       'password_manager/core/browser/affiliation_service_unittest.cc',
       'password_manager/core/browser/affiliation_utils_unittest.cc',
       'password_manager/core/browser/browser_save_password_progress_logger_unittest.cc',
       'password_manager/core/browser/export/csv_writer_unittest.cc',
       'password_manager/core/browser/export/password_csv_writer_unittest.cc',
       'password_manager/core/browser/export/password_exporter_unittest.cc',
       'password_manager/core/browser/facet_manager_unittest.cc',
       'password_manager/core/browser/import/csv_reader_unittest.cc',
+      'password_manager/core/browser/import/password_csv_reader_unittest.cc',
       'password_manager/core/browser/import/password_importer_unittest.cc',
-      'password_manager/core/browser/import/password_csv_reader_unittest.cc',
       'password_manager/core/browser/log_manager_unittest.cc',
       'password_manager/core/browser/log_router_unittest.cc',
       'password_manager/core/browser/login_database_ios_unittest.cc',
       'password_manager/core/browser/login_database_unittest.cc',
       'password_manager/core/browser/login_model_unittest.cc',
       'password_manager/core/browser/mock_affiliated_match_helper.cc',
       'password_manager/core/browser/mock_affiliated_match_helper.h',
       'password_manager/core/browser/password_autofill_manager_unittest.cc',
       'password_manager/core/browser/password_bubble_experiment_unittest.cc',
       'password_manager/core/browser/password_form_manager_unittest.cc',
@@ skipping 279 matching lines @@
       'sync_driver/about_sync_util_unittest.cc',
       'sync_driver/backend_migrator_unittest.cc',
       'sync_driver/data_type_manager_impl_unittest.cc',
       'sync_driver/device_count_metrics_provider_unittest.cc',
       'sync_driver/device_info_data_type_controller_unittest.cc',
       'sync_driver/device_info_service_unittest.cc',
       'sync_driver/device_info_sync_service_unittest.cc',
       'sync_driver/device_info_util_unittest.cc',
       'sync_driver/frontend_data_type_controller_unittest.cc',
       'sync_driver/generic_change_processor_unittest.cc',
+      'sync_driver/glue/browser_thread_model_worker_unittest.cc',
       'sync_driver/glue/sync_backend_host_impl_unittest.cc',
-      'sync_driver/glue/browser_thread_model_worker_unittest.cc',
       'sync_driver/glue/sync_backend_registrar_unittest.cc',
       'sync_driver/glue/ui_model_worker_unittest.cc',
       'sync_driver/local_device_info_provider_unittest.cc',
       'sync_driver/model_association_manager_unittest.cc',
       'sync_driver/non_blocking_data_type_controller_unittest.cc',
       'sync_driver/non_ui_data_type_controller_unittest.cc',
       'sync_driver/non_ui_model_type_controller_unittest.cc',
       'sync_driver/profile_sync_auth_provider_unittest.cc',
       'sync_driver/shared_change_processor_unittest.cc',
       'sync_driver/startup_controller_unittest.cc',
       'sync_driver/sync_prefs_unittest.cc',
       'sync_driver/sync_stopped_reporter_unittest.cc',
       'sync_driver/sync_util_unittest.cc',
       'sync_driver/system_encryptor_unittest.cc',
       'sync_driver/ui_data_type_controller_unittest.cc',
       'sync_driver/ui_model_type_controller_unittest.cc',
     ],
     'sync_sessions_unittest_sources': [
       'sync_sessions/favicon_cache_unittest.cc',
       'sync_sessions/revisit/bookmarks_page_revisit_observer_unittest.cc',
       'sync_sessions/revisit/current_tab_matcher_unittest.cc',
       'sync_sessions/revisit/offset_tab_matcher_unittest.cc',
       'sync_sessions/revisit/page_revisit_broadcaster_unittest.cc',
       'sync_sessions/revisit/sessions_page_revisit_observer_unittest.cc',
       'sync_sessions/revisit/typed_url_page_revisit_task_unittest.cc',
       'sync_sessions/session_data_type_controller_unittest.cc',
+      'sync_sessions/sync_sessions_metrics_unittest.cc',
       'sync_sessions/synced_session_tracker_unittest.cc',
-      'sync_sessions/sync_sessions_metrics_unittest.cc',
       'sync_sessions/tab_node_pool_unittest.cc',
     ],
     'syncable_prefs_unittest_sources': [
       'syncable_prefs/pref_model_associator_unittest.cc',
       'syncable_prefs/pref_service_syncable_unittest.cc',
     ],
     'tracing_unittest_sources': [
       'tracing/browser/trace_config_file_unittest.cc',
       'tracing/common/graphics_memory_dump_provider_android_unittest.cc',
       'tracing/common/process_metrics_memory_dump_provider_unittest.cc',
     ],
     'translate_unittest_sources': [
+      'translate/core/browser/language_state_unittest.cc',
       'translate/core/browser/mock_translate_driver.cc',
-      'translate/core/browser/language_state_unittest.cc',
       'translate/core/browser/translate_browser_metrics_unittest.cc',
       'translate/core/browser/translate_language_list_unittest.cc',
       'translate/core/browser/translate_manager_unittest.cc',
       'translate/core/browser/translate_prefs_unittest.cc',
       'translate/core/browser/translate_script_unittest.cc',
       'translate/core/browser/translate_ui_delegate_unittest.cc',
       'translate/core/common/translate_metrics_unittest.cc',
       'translate/core/common/translate_util_unittest.cc',
       'translate/core/language_detection/language_detection_util_unittest.cc',
       'translate/ios/browser/js_translate_manager_unittest.mm',
@@ skipping 1127 matching lines @@
               'dependencies': [
                 '../tools/xdisplaycheck/xdisplaycheck.gyp:xdisplaycheck',
               ],
             }],
           ],
         },
       ],
     }],
   ],
 }