components/offline_pages/background/DEPS - Issue 2053163002: [Offline pages] Adding persistent request queue based on SQLite

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/offline_pages/background/DEPS

Issue 2053163002: [Offline pages] Adding persistent request queue based on SQLite (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updating the data definition code and getting rid of the enum to access columns Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « components/offline_pages/background/BUILD.gn ('k') | components/offline_pages/background/request_queue.cc » ('j') | components/offline_pages/background/request_queue_store_sql.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+gpu",	2 "+sql",
Scott Hess - ex-Googler 2016/06/22 18:31:45 Was that dependency just wrong previously? A plac Was that dependency just wrong previously? A placeholder of some sort to keep the file valid? fgorski 2016/06/22 23:32:16 I think this is simply problem with diffing. I don Show quoted text On 2016/06/22 18:31:45, Scott Hess wrote: > Was that dependency just wrong previously? A placeholder of some sort to keep > the file valid? I think this is simply problem with diffing. I don't think we had a file here at all. Scott Hess - ex-Googler 2016/06/22 23:46:06 Ha, should have checked that - it's marked A+, so Show quoted text On 2016/06/22 23:32:16, fgorski wrote: > On 2016/06/22 18:31:45, Scott Hess wrote: > > Was that dependency just wrong previously? A placeholder of some sort to keep > > the file valid? > > I think this is simply problem with diffing. I don't think we had a file here at > all. Ha, should have checked that - it's marked A+, so it's an added file and someone is using a similarity algorithm to try to handle the moved-file case.
3 ]	3 ]

OLD	NEW