components/offline_pages/background/save_page_request_unittest.cc - Issue 2053163002: [Offline pages] Adding persistent request queue based on SQLite

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/offline_pages/background/save_page_request_unittest.cc

Issue 2053163002: [Offline pages] Adding persistent request queue based on SQLite (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing code review feedback from petewil Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/offline_pages/background/request_queue_store_sql.cc ('K') | « components/offline_pages/background/save_page_request.h ('k') | no next file » | no next file with comments »

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "components/offline_pages/background/save_page_request.h"	5 #include "components/offline_pages/background/save_page_request.h"

6	6

7 #include "testing/gtest/include/gtest/gtest.h"	7 #include "testing/gtest/include/gtest/gtest.h"

8	8

9 namespace offline_pages {	9 namespace offline_pages {

10	10

(...skipping 72 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
83	83

84 request.MarkAttemptCompleted();	84 request.MarkAttemptCompleted();

85	85

86 // Again, most things don't change about the request.	86 // Again, most things don't change about the request.

87 ASSERT_EQ(kRequestId, request.request_id());	87 ASSERT_EQ(kRequestId, request.request_id());

88 ASSERT_EQ(kUrl, request.url());	88 ASSERT_EQ(kUrl, request.url());

89 ASSERT_EQ(kClientId, request.client_id());	89 ASSERT_EQ(kClientId, request.client_id());

90 ASSERT_EQ(creation_time, request.creation_time());	90 ASSERT_EQ(creation_time, request.creation_time());

91 ASSERT_EQ(activation_time, request.activation_time());	91 ASSERT_EQ(activation_time, request.activation_time());

92	92

93 // Last attempt time and status will. Attempt count also unchanged.	93 // Last attempt time, status and attempt count is updated.
	Scott Hess - ex-Googler 2016/06/20 19:38:33 "are updated" "are updated" fgorski 2016/06/20 23:43:00 Done. Show quoted text On 2016/06/20 19:38:33, Scott Hess wrote: > "are updated" Done.
94 ASSERT_EQ(base::Time(), request.last_attempt_time());	94 ASSERT_EQ(base::Time(), request.last_attempt_time());

95 ASSERT_EQ(1, request.attempt_count());	95 ASSERT_EQ(1, request.attempt_count());

96

97 ASSERT_EQ(SavePageRequest::Status::PENDING, request.GetStatus(start_time));	96 ASSERT_EQ(SavePageRequest::Status::PENDING, request.GetStatus(start_time));

98 }	97 }

99	98

100 } // offline_pages	99 } // offline_pages

OLD	NEW