Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Issue 2053153003: Add OWNERS, update README.chromium in Chromium's gRPC repo. (Closed)

Created:
4 years, 6 months ago by xyzzyz
Modified:
4 years, 2 months ago
Reviewers:
marcinjb, yangxiaomin08
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/external/github.com/grpc/grpc@chromium
Target Ref:
refs/heads/chromium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
A OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M README.chromium View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
xyzzyz
4 years, 6 months ago (2016-06-09 23:34:02 UTC) #2
marcinjb
lgtm
4 years, 6 months ago (2016-06-09 23:37:30 UTC) #3
xyzzyz
Committed patchset #1 (id:1) manually as c1f618fb61b5258c1718e7ae60a6a7dbf6f912fb (presubmit successful).
4 years, 6 months ago (2016-06-09 23:37:49 UTC) #5
yangxiaomin08_gmail.com
4 years, 2 months ago (2016-09-29 06:38:20 UTC) #6
Message was sent while issue was closed.
How to build the gRPC?

I used gn ls out/Default | grep rpc but nothing was found. 


在 2016年6月10日星期五 UTC+8上午7:34:03,xyz...@chromium.org写道:
>
> Reviewers: marcinjb
> CL: https://codereview.chromium.org/2053153003/
>
> Description:
> Add OWNERS, update README.chromium in Chromium's gRPC repo.
>
> BUG=
>
> Base URL: 
> https://chromium.googlesource.com/external/github.com/grpc/grpc@chromium
>
> Affected files (+5, -1 lines):
> A OWNERS
> M README.chromium
>
>
> Index: OWNERS
> diff --git a/OWNERS b/OWNERS
> new file mode 100644
> index 
>
0000000000000000000000000000000000000000..01b8f816c6cc1b8761d9c8859ad352f33aab56d5
> --- /dev/null
> +++ b/OWNERS
> @@ -0,0 +1,2 @@
> +xy...@chromium.org <javascript:>
> +mani...@chromium.org <javascript:>
> Index: README.chromium
> diff --git a/README.chromium b/README.chromium
> index 
>
0b79b507541e6d1d3b5ec83884594696dbe84b01..172fad4a0349cc4bed30d1b2f9a87d53c2ce6c1f

> 100644
> --- a/README.chromium
> +++ b/README.chromium
> @@ -2,7 +2,9 @@ Name: gRPC, an RPC library and framework
> Short Name: gRPC
> URL: https://github.com/grpc/grpc
> License: BSD-style, copyright Google
> -Security Critical: no
> +License File: LICENSE
> +Revision: 1bc2976a0f51e14d3525aecbf4b3450445ed2d1b
> +Security Critical: yes
>
> This directory contains Chrome's version of the C-version of the gRPC
> library.
>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698