Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 2053143003: When a test class is named SoloTest, run it using solo_group(). (Closed)

Created:
4 years, 6 months ago by scheglov
Modified:
4 years, 6 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

When a test class is named SoloTest, run it using solo_group(). So, we can quickly run a single test suite without commenting ont other classes in main(). Still have to rename the test class. though... R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/0ce19821fced7c6145c83f08d617baca6995a8ff

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M pkg/analyzer/test/reflective_tests.dart View 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 6 months ago (2016-06-10 22:04:24 UTC) #1
Brian Wilkerson
lgtm, but perhaps an annotation on the class "@solo" would be a better solution.
4 years, 6 months ago (2016-06-10 22:07:15 UTC) #2
Paul Berry
lgtm
4 years, 6 months ago (2016-06-10 22:07:17 UTC) #3
scheglov
4 years, 6 months ago (2016-06-11 01:52:47 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0ce19821fced7c6145c83f08d617baca6995a8ff (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698