Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 2053143002: Supports multiple profiles when DiskCacheDir is overridden by command line switches or group policy. (Closed)

Created:
4 years, 6 months ago by zmin
Modified:
4 years, 6 months ago
Reviewers:
anthonyvd
CC:
chromium-reviews, chrome-enterprise-changes_google.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Supports multiple profiles when DiskCacheDir is overridden by command line switches or group policy. BUG=611215 Committed: https://crrev.com/c38cac52085b69b2fc933efef66aa344eddbff7d Cr-Commit-Position: refs/heads/master@{#399816}

Patch Set 1 #

Patch Set 2 : add browser test #

Patch Set 3 : fix linux trybot failure #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -1 line) Patch
M chrome/browser/profiles/profile_browsertest.cc View 1 2 1 chunk +32 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_impl.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 18 (8 generated)
zmin
Hi Anthony, Can you please review the CL? Best, Owen
4 years, 6 months ago (2016-06-09 22:09:13 UTC) #3
anthonyvd
On 2016/06/09 at 22:09:13, zmin wrote: > Hi Anthony, > > Can you please review ...
4 years, 6 months ago (2016-06-14 13:07:58 UTC) #4
zmin
On 2016/06/14 13:07:58, anthonyvd wrote: > On 2016/06/09 at 22:09:13, zmin wrote: > > Hi ...
4 years, 6 months ago (2016-06-14 19:28:32 UTC) #5
anthonyvd
On 2016/06/14 at 19:28:32, zmin wrote: > On 2016/06/14 13:07:58, anthonyvd wrote: > > On ...
4 years, 6 months ago (2016-06-14 21:07:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053143002/20001
4 years, 6 months ago (2016-06-14 21:17:06 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/203257) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 6 months ago (2016-06-14 21:29:40 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053143002/40001
4 years, 6 months ago (2016-06-15 00:44:41 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-15 01:48:47 UTC) #15
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-15 01:48:54 UTC) #16
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 01:50:16 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c38cac52085b69b2fc933efef66aa344eddbff7d
Cr-Commit-Position: refs/heads/master@{#399816}

Powered by Google App Engine
This is Rietveld 408576698