Supports multiple profiles when DiskCacheDir is overridden by command line switches or group policy.

Supports multiple profiles when DiskCacheDir is overridden by command line switches or group policy.

BUG=611215
Committed: https://crrev.com/c38cac52085b69b2fc933efef66aa344eddbff7d
Cr-Commit-Position: refs/heads/master@{#399816}

[zmin, 2016-06-09 22:08:09]

Description was changed from

==========
Supports multiple profiles when DiskCacheDir is overridden by command line
switches or group policy.

BUG=611215
==========

to

==========
Supports multiple profiles when DiskCacheDir is overridden by command line
switches or group policy.

BUG=611215
==========

[zmin, 2016-06-09 22:08:10]

zmin@chromium.org changed reviewers:
+ anthonyvd@chromium.org

[zmin, 2016-06-09 22:09:13]

Hi Anthony,

Can you please review the CL?


Best,
Owen

[anthonyvd, 2016-06-14 13:07:58]

On 2016/06/09 at 22:09:13, zmin wrote:
> Hi Anthony,
> 
> Can you please review the CL?
> 
> 
> Best,
> Owen

Hi Owen, sorry for the delay, I was OoO for a few days. Do we have a unit test
for this? If we don't, can you please add one?

Thanks!

[zmin, 2016-06-14 19:28:32]

On 2016/06/14 13:07:58, anthonyvd wrote:
> On 2016/06/09 at 22:09:13, zmin wrote:
> > Hi Anthony,
> > 
> > Can you please review the CL?
> > 
> > 
> > Best,
> > Owen
> 
> Hi Owen, sorry for the delay, I was OoO for a few days. Do we have a unit test
> for this? If we don't, can you please add one?
> 
> Thanks!

Add a browser test.

[anthonyvd, 2016-06-14 21:07:57]

On 2016/06/14 at 19:28:32, zmin wrote:
> On 2016/06/14 13:07:58, anthonyvd wrote:
> > On 2016/06/09 at 22:09:13, zmin wrote:
> > > Hi Anthony,
> > > 
> > > Can you please review the CL?
> > > 
> > > 
> > > Best,
> > > Owen
> > 
> > Hi Owen, sorry for the delay, I was OoO for a few days. Do we have a unit
test
> > for this? If we don't, can you please add one?
> > 
> > Thanks!
> 
> Add a browser test.

Thanks! lgtm

[zmin, 2016-06-14 21:16:14]

The CQ bit was checked by zmin@chromium.org

[commit-bot: I haz the power, 2016-06-14 21:17:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2053143002/20001

[commit-bot: I haz the power, 2016-06-14 21:29:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-14 21:29:40]

Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[zmin, 2016-06-15 00:43:46]

The CQ bit was checked by zmin@chromium.org

[zmin, 2016-06-15 00:43:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
anthonyvd@chromium.org
Link to the patchset: https://codereview.chromium.org/2053143002/#ps40001
(title: "fix linux trybot failure")

[commit-bot: I haz the power, 2016-06-15 00:44:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2053143002/40001

[commit-bot: I haz the power, 2016-06-15 01:48:47]

Description was changed from

==========
Supports multiple profiles when DiskCacheDir is overridden by command line
switches or group policy.

BUG=611215
==========

to

==========
Supports multiple profiles when DiskCacheDir is overridden by command line
switches or group policy.

BUG=611215
==========

[commit-bot: I haz the power, 2016-06-15 01:48:47]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-15 01:48:54]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-15 01:50:15]

Description was changed from

==========
Supports multiple profiles when DiskCacheDir is overridden by command line
switches or group policy.

BUG=611215
==========

to

==========
Supports multiple profiles when DiskCacheDir is overridden by command line
switches or group policy.

BUG=611215

Committed: https://crrev.com/c38cac52085b69b2fc933efef66aa344eddbff7d
Cr-Commit-Position: refs/heads/master@{#399816}
==========

[commit-bot: I haz the power, 2016-06-15 01:50:16]

Patchset 3 (id:??) landed as
https://crrev.com/c38cac52085b69b2fc933efef66aa344eddbff7d
Cr-Commit-Position: refs/heads/master@{#399816}