Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 205313002: Revert 258077 "Remove PrepareForShutdown" (Closed)

Created:
6 years, 9 months ago by brettw
Modified:
6 years, 9 months ago
Reviewers:
oshima
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 258077 "Remove PrepareForShutdown" Broke Linux official builder: http://build.chromium.org/p/chromium/builders/Linux/builds/48352/steps/compile/logs/stdio ../../apps/shell/browser/shell_browser_main_parts.cc:197:42:error: 'class aura::WindowEventDispatcher' has no member named 'PrepareForShutdown' ninja: build stopped: subcommand failed. > Remove PrepareForShutdown > Filter events after shutdown in event filter instead. > > BUG=None > > Review URL: https://codereview.chromium.org/196573023 TBR=oshima@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258103

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -21 lines) Patch
M trunk/src/ash/display/mouse_cursor_event_filter.cc View 3 chunks +2 lines, -10 lines 0 comments Download
M trunk/src/ash/display/screen_ash.cc View 1 chunk +1 line, -5 lines 0 comments Download
M trunk/src/ash/root_window_controller.cc View 1 chunk +2 lines, -1 line 0 comments Download
M trunk/src/ash/root_window_settings.h View 1 chunk +0 lines, -3 lines 0 comments Download
M trunk/src/ash/root_window_settings.cc View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/mojo/examples/aura_demo/window_tree_host_mojo.h View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/mojo/examples/aura_demo/window_tree_host_mojo.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/src/ui/aura/remote_window_tree_host_win.h View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/ui/aura/remote_window_tree_host_win.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M trunk/src/ui/aura/window_event_dispatcher.h View 1 chunk +3 lines, -0 lines 0 comments Download
M trunk/src/ui/aura/window_event_dispatcher.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M trunk/src/ui/aura/window_tree_host.h View 1 chunk +3 lines, -0 lines 0 comments Download
M trunk/src/ui/aura/window_tree_host_mac.h View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/ui/aura/window_tree_host_mac.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/src/ui/aura/window_tree_host_ozone.h View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/ui/aura/window_tree_host_ozone.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M trunk/src/ui/aura/window_tree_host_win.h View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/ui/aura/window_tree_host_win.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/src/ui/aura/window_tree_host_x11.h View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/ui/aura/window_tree_host_x11.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/src/ui/views/widget/desktop_aura/desktop_window_tree_host_win.h View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M trunk/src/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
6 years, 9 months ago (2014-03-19 21:26:57 UTC) #1
brettw
6 years, 9 months ago (2014-03-19 21:29:02 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 manually as r258103 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698