Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 2053123002: Remove MessageLoop::current()->RunUntilIdle() in media. (Closed)

Created:
4 years, 6 months ago by fdoray
Modified:
4 years, 6 months ago
Reviewers:
chcunningham
CC:
chromium-reviews, imcheng+watch_chromium.org, posciak+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, feature-media-reviews_chromium.org, mcasas+watch+vc_chromium.org, xjz+watch_chromium.org, isheriff+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove MessageLoop::current()->RunUntilIdle() in media. This CL replaces MessageLoop::current()->RunUntilIdle() with RunLoop().RunUntilIdle() in media. In files where this replacement is made, it adds this include: #include "base/run_loop.h" And removes this include if it is no longer required: #include "base/message_loop/message_loop.h" Why? - The fact that there's a MessageLoop on the thread is an unnecessary implementation detail. When browser threads are migrated to base/task_scheduler, tasks will no longer have access to a MessageLoop but they will be able to use RunLoop. - MessageLoop::RunUntilIdle() is deprecated. Steps to generate this patch: 1. Run message_loop_cleanup_3.py (see code on the bug). 2. Run tools/sort-headers.py on modified files. 3. Run git cl format. BUG=616447 R=chcunningham@chromium.org Committed: https://crrev.com/1cb10e0a8639c96fa8a54da0b95412e0ef8d3505 Cr-Commit-Position: refs/heads/master@{#399238}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -11 lines) Patch
M media/blink/buffered_resource_loader_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M media/blink/resource_multibuffer_data_provider_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M media/capture/video/fake_video_capture_device_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/capture/video/video_capture_device_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/sender/h264_vt_encoder_unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M media/filters/chunk_demuxer_unittest.cc View 4 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
fdoray
Can you review this CL? Thanks.
4 years, 6 months ago (2016-06-09 22:52:02 UTC) #1
chcunningham
lgtm
4 years, 6 months ago (2016-06-10 17:17:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053123002/1
4 years, 6 months ago (2016-06-10 17:28:54 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-10 18:45:33 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 18:46:47 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1cb10e0a8639c96fa8a54da0b95412e0ef8d3505
Cr-Commit-Position: refs/heads/master@{#399238}

Powered by Google App Engine
This is Rietveld 408576698