Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2053113003: [Layout API] Use Document::layoutViewItem in WebFrameTest (Closed)

Created:
4 years, 6 months ago by pilgrim_google
Modified:
4 years, 5 months ago
Reviewers:
tkent, eae, jsbell
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, dgrogan, eae+blinkwatch, jchaffraix+rendering, kinuko+watch, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Layout API] Use Document::layoutViewItem in WebFrameTest Document::layoutView() is deprecated and close to being removed altogether. This CL migrates WebFrameTest to use the comparable layoutViewItem() method. I had to add LayoutItem::mutableStyleRef() to the block layout API. There are no functional changes. BUG=499321 Committed: https://crrev.com/7e21fa1d122ce05b3d121d8a520f8b5e9bc66dae Cr-Commit-Position: refs/heads/master@{#402289}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -13 lines) Patch
M third_party/WebKit/Source/core/layout/api/LayoutItem.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 1 4 chunks +13 lines, -13 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
pilgrim_google
+tkent because web/
4 years, 6 months ago (2016-06-10 13:15:07 UTC) #2
tkent
lgtm
4 years, 6 months ago (2016-06-12 23:13:34 UTC) #3
eae
LGTM
4 years, 6 months ago (2016-06-21 09:19:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2053113003/20001
4 years, 5 months ago (2016-06-27 18:55:35 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-27 21:29:02 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 21:31:04 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7e21fa1d122ce05b3d121d8a520f8b5e9bc66dae
Cr-Commit-Position: refs/heads/master@{#402289}

Powered by Google App Engine
This is Rietveld 408576698