Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1893)

Unified Diff: ash/shelf/shelf_layout_manager.cc

Issue 2053113002: Replaced BackgroundAnimator with ShelfBackgroundAnimator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Made the ShelfView add/remove itself as an observer from the ShelfBackgroundAnimator. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/shelf/shelf_layout_manager.cc
diff --git a/ash/shelf/shelf_layout_manager.cc b/ash/shelf/shelf_layout_manager.cc
index e1c3425d7c8666b1db189f581efbe6afc12e50fc..1ffee670ee7a8d0bdfd5f49a78f777f7ad3ab982 100644
--- a/ash/shelf/shelf_layout_manager.cc
+++ b/ash/shelf/shelf_layout_manager.cc
@@ -586,6 +586,22 @@ bool ShelfLayoutManager::IsHorizontalAlignment() const {
return ::ash::IsHorizontalAlignment(GetAlignment());
}
+ShelfBackgroundType ShelfLayoutManager::GetShelfBackgroundType() const {
+ if (state_.visibility_state != SHELF_AUTO_HIDE &&
+ state_.window_state == wm::WORKSPACE_WINDOW_STATE_MAXIMIZED) {
+ return SHELF_BACKGROUND_MAXIMIZED;
+ }
+
+ if (gesture_drag_status_ == GESTURE_DRAG_IN_PROGRESS ||
+ (!state_.is_screen_locked && !state_.is_adding_user_screen &&
+ window_overlaps_shelf_) ||
+ (state_.visibility_state == SHELF_AUTO_HIDE)) {
+ return SHELF_BACKGROUND_OVERLAP;
+ }
+
+ return SHELF_BACKGROUND_DEFAULT;
+}
+
void ShelfLayoutManager::SetChromeVoxPanelHeight(int height) {
chromevox_panel_height_ = height;
LayoutShelf();
@@ -973,27 +989,10 @@ void ShelfLayoutManager::UpdateTargetBoundsForGesture(
void ShelfLayoutManager::UpdateShelfBackground(
BackgroundAnimatorChangeType type) {
const ShelfBackgroundType background_type(GetShelfBackgroundType());
- shelf_widget_->SetPaintsBackground(background_type, type);
FOR_EACH_OBSERVER(ShelfLayoutManagerObserver, observers_,
OnBackgroundUpdated(background_type, type));
}
-ShelfBackgroundType ShelfLayoutManager::GetShelfBackgroundType() const {
- if (state_.visibility_state != SHELF_AUTO_HIDE &&
- state_.window_state == wm::WORKSPACE_WINDOW_STATE_MAXIMIZED) {
- return SHELF_BACKGROUND_MAXIMIZED;
- }
-
- if (gesture_drag_status_ == GESTURE_DRAG_IN_PROGRESS ||
- (!state_.is_screen_locked && !state_.is_adding_user_screen &&
- window_overlaps_shelf_) ||
- (state_.visibility_state == SHELF_AUTO_HIDE)) {
- return SHELF_BACKGROUND_OVERLAP;
- }
-
- return SHELF_BACKGROUND_DEFAULT;
-}
-
void ShelfLayoutManager::UpdateAutoHideStateNow() {
SetState(state_.visibility_state);

Powered by Google App Engine
This is Rietveld 408576698