ash/common/shelf/wm_shelf_observer.h - Issue 2053113002: Replaced BackgroundAnimator with ShelfBackgroundAnimator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/common/shelf/wm_shelf_observer.h

Issue 2053113002: Replaced BackgroundAnimator with ShelfBackgroundAnimator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added PaletteTray to the Shelf background animations. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ash/common/shelf/shelf_background_animator_unittest.cc ('K') | « ash/common/shelf/shelf_background_animator_unittest.cc ('k') | ash/common/system/chromeos/power/power_status_unittest.cc » ('j') | ash/common/system/status_area_widget.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ash/common/shelf/wm_shelf_observer.h

diff --git a/ash/common/shelf/wm_shelf_observer.h b/ash/common/shelf/wm_shelf_observer.h

index ae32562eab8b64b999a738cfa859c6d7a832b88e..7c81cf1d5b7b5c655f4135fd1cd28127cadbeb6d 100644

--- a/ash/common/shelf/wm_shelf_observer.h

+++ b/ash/common/shelf/wm_shelf_observer.h

@@ -14,7 +14,7 @@ namespace ash {

// Used to observe changes to the shelf.

class ASH_EXPORT WmShelfObserver {

public:

- virtual void OnBackgroundUpdated(ShelfBackgroundType background_type,

+ virtual void OnBackgroundChanged(ShelfBackgroundType background_type,

James Cook 2016/07/27 00:30:39 Please add a comment about the semantics of this m

bruthig 2016/07/27 17:05:45 Done. Opted for the later suggestion.

BackgroundAnimatorChangeType change_type) {}

virtual void WillChangeVisibilityState(ShelfVisibilityState new_state) {}

virtual void OnAutoHideStateChanged(ShelfAutoHideState new_state) {}