Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(750)

Issue 2052963002: Mojo C++ bindings: don't DCEHCK in Binding::Close() when the binding is not bound. (Closed)

Created:
4 years, 6 months ago by yzshen1
Modified:
4 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: don't DCEHCK in Binding::Close() when the binding is not bound. BUG=618488 Committed: https://crrev.com/3e75809d6084ec6ae9694cc5ba20990be37ec49a Cr-Commit-Position: refs/heads/master@{#399059}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -10 lines) Patch
M mojo/public/cpp/bindings/lib/binding_state.h View 4 chunks +8 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
yzshen1
Hi, Scott. Would you please take a look? Thanks!
4 years, 6 months ago (2016-06-09 18:08:10 UTC) #2
sky
Nice, thanks, LGTM
4 years, 6 months ago (2016-06-09 21:11:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2052963002/20001
4 years, 6 months ago (2016-06-09 21:13:05 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-10 00:49:35 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-10 00:49:52 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 00:52:05 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3e75809d6084ec6ae9694cc5ba20990be37ec49a
Cr-Commit-Position: refs/heads/master@{#399059}

Powered by Google App Engine
This is Rietveld 408576698