Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2052913002: For Offliner, pass in the URL from WebContents to SavePage request instead of the request URL since… (Closed)

Created:
4 years, 6 months ago by dougarnett
Modified:
4 years, 6 months ago
CC:
chromium-reviews, davidben+watch_chromium.org, cbentzel+watch_chromium.org, romax+watch_chromium.org, tburkard+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, gavinp+prer_chromium.org, dimich+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@moreturnon
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

For Offliner, pass in the URL from WebContents to SavePage request instead of the request URL since redirect link will fail a URL check in OfflinePageModelImpl. This is workaround until better understand how to deal with redirected URLs for async loading. BUG=618716 Committed: https://crrev.com/e759fe98d6b70f487d5f5474b00703d1ba492d53 Cr-Commit-Position: refs/heads/master@{#399001}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M chrome/browser/android/offline_pages/prerendering_offliner.cc View 2 chunks +8 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (5 generated)
dougarnett
Pete, here is another CL to patch to help more links works (although you could ...
4 years, 6 months ago (2016-06-09 15:47:41 UTC) #3
Pete Williamson
lgtm
4 years, 6 months ago (2016-06-09 16:52:56 UTC) #4
fgorski
lgtm
4 years, 6 months ago (2016-06-09 17:13:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2052913002/1
4 years, 6 months ago (2016-06-09 20:30:05 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-09 20:45:29 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-09 20:45:35 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 20:47:09 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e759fe98d6b70f487d5f5474b00703d1ba492d53
Cr-Commit-Position: refs/heads/master@{#399001}

Powered by Google App Engine
This is Rietveld 408576698