Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2052873002: [generators] Make runtime functions more robust. (Closed)

Created:
4 years, 6 months ago by neis
Modified:
4 years, 6 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[generators] Make runtime functions more robust. Only look at the --ignition-generators flag when determining whether to use Ignition (in compiler.cc). In generator runtime functions, instead of looking at the flag, determine the generator kind based on whether the generator has a bytecode array. This allows compiling some generator function using full-codegen and others using Ignition, e.g when using --ignition-filter. R=mstarzinger@chromium.org BUG=chromium:618657, v8:4907 Committed: https://crrev.com/54b405ce656873c894b702cbad95f5d374a94428 Cr-Commit-Position: refs/heads/master@{#36864}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M src/runtime/runtime-generator.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A test/mjsunit/regress/regress-618657.js View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
neis
4 years, 6 months ago (2016-06-09 13:33:46 UTC) #1
neis
PTAL
4 years, 6 months ago (2016-06-09 13:34:32 UTC) #3
Michael Starzinger
LGTM. Thanks!
4 years, 6 months ago (2016-06-09 13:38:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2052873002/1
4 years, 6 months ago (2016-06-09 13:39:56 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-09 14:18:33 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-09 14:18:35 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 14:21:12 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/54b405ce656873c894b702cbad95f5d374a94428
Cr-Commit-Position: refs/heads/master@{#36864}

Powered by Google App Engine
This is Rietveld 408576698