Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Issue 2052843002: infra_continuous: use a short path for DEPOT_TOOLS_GSUTIL_BIN_DIR (Closed)

Created:
4 years, 6 months ago by Paweł Hajdan Jr.
Modified:
4 years, 6 months ago
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

infra_continuous: use a short path for DEPOT_TOOLS_GSUTIL_BIN_DIR This is a speculative fix for long path names on Windows. BUG=617565 R=sergiyb@chromium.org, tandrii@chromium.org Committed: https://chromium.googlesource.com/infra/infra/+/a84d878c09614009b8fbf3ee6d941dd78649b28d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M recipes/recipes/infra_continuous.py View 2 chunks +3 lines, -1 line 0 comments Download
M recipes/recipes/infra_continuous.expected/infra-64.json View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Paweł Hajdan Jr.
This is intended to tackle https://build.chromium.org/p/chromium.infra/builders/infra-continuous-win-64/builds/2198
4 years, 6 months ago (2016-06-09 12:08:40 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2052843002/1
4 years, 6 months ago (2016-06-09 12:08:47 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-09 12:55:40 UTC) #6
Sergiy Byelozyorov
lgtm
4 years, 6 months ago (2016-06-09 13:27:33 UTC) #7
tandrii(chromium)
LGTM though it'd be nice if you had put a url to DEPOT_TOOLS_GSUTIL_BIN_DIR def and ...
4 years, 6 months ago (2016-06-09 13:28:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2052843002/1
4 years, 6 months ago (2016-06-09 13:29:09 UTC) #10
Paweł Hajdan Jr.
Committed patchset #1 (id:1) manually as a84d878c09614009b8fbf3ee6d941dd78649b28d.
4 years, 6 months ago (2016-06-09 13:38:23 UTC) #12
nodir
This broke experimental swarmbucket builders. Please update swarmbucket configs when you move recipes, e.g. https://chromium.googlesource.com/infra/infra/+/infra/config/cr-buildbucket.cfg
4 years, 6 months ago (2016-06-10 18:11:39 UTC) #14
nodir
4 years, 6 months ago (2016-06-10 18:12:54 UTC) #15
Message was sent while issue was closed.
On 2016/06/10 18:11:39, nodir wrote:
> This broke experimental swarmbucket builders. Please update swarmbucket
configs
> when you move recipes, e.g.
>
https://chromium.googlesource.com/infra/infra/+/infra/config/cr-buildbucket.cfg

ignore this. this message is for a different CL

Powered by Google App Engine
This is Rietveld 408576698