Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2052833003: S390: [stubs] StringToNumberStub --> StringToNumber builtin. (Closed)

Created:
4 years, 6 months ago by john.yan
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: [stubs] StringToNumberStub --> StringToNumber builtin. port 546dd77ffcccce42a5751b24bddaa8295efefb4b Original Commit Message: Since some builtins use StringToNumberStub (so the code is always there), it makes more sense to have StringToNumber builtin. R=jarin@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com, bjaideep@ca.ibm.com BUG= Committed: https://crrev.com/cb05c2df7cbacd94dd1061d4771ad0ea59019044 Cr-Commit-Position: refs/heads/master@{#36872}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -19 lines) Patch
M src/s390/builtins-s390.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M src/s390/code-stubs-s390.cc View 2 chunks +1 line, -19 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
john.yan
PTAL
4 years, 6 months ago (2016-06-09 17:03:36 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2052833003/1
4 years, 6 months ago (2016-06-09 17:10:26 UTC) #3
michael_dawson
On 2016/06/09 17:10:26, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
4 years, 6 months ago (2016-06-09 17:17:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2052833003/1
4 years, 6 months ago (2016-06-09 17:21:46 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-09 17:31:20 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 17:34:19 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cb05c2df7cbacd94dd1061d4771ad0ea59019044
Cr-Commit-Position: refs/heads/master@{#36872}

Powered by Google App Engine
This is Rietveld 408576698