Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 2052823002: Update import order CheckStyle configuration. (Closed)

Created:
4 years, 6 months ago by Bernhard Bauer
Modified:
4 years, 2 months ago
Reviewers:
aberent, jbudorick
CC:
chromium-reviews, tfarina, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update import order CheckStyle configuration. The import order now separates Chromium (and downstream) imports from other imports with com or org prefixes. Also remove some prefixes that aren't used in Chromium code. Finally, add an importorder file for configuring the import order in Eclipse. Committed: https://crrev.com/ba39aa11d397ca1768ae2a702bec32aab9283770 Cr-Commit-Position: refs/heads/master@{#422818}

Patch Set 1 #

Patch Set 2 : x #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M tools/android/checkstyle/chromium-style-5.0.xml View 1 1 chunk +2 lines, -2 lines 0 comments Download
A tools/android/eclipse/android.importorder View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
Bernhard Bauer
Please review. Thanks!
4 years, 5 months ago (2016-07-12 09:38:51 UTC) #3
aberent
lgtm
4 years, 5 months ago (2016-07-12 10:11:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2052823002/20001
4 years, 3 months ago (2016-09-09 10:21:50 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/256422)
4 years, 3 months ago (2016-09-09 10:27:32 UTC) #8
Bernhard Bauer
John, could I get an OWNERS review please?
4 years, 3 months ago (2016-09-09 10:46:42 UTC) #10
Bernhard Bauer
On 2016/09/09 10:46:42, Bernhard Bauer wrote: > John, could I get an OWNERS review please? ...
4 years, 2 months ago (2016-10-04 14:24:09 UTC) #11
jbudorick
:O sorry, this got lost in my inbox somewhere. lgtm
4 years, 2 months ago (2016-10-04 15:12:32 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2052823002/20001
4 years, 2 months ago (2016-10-04 15:30:25 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-04 16:04:36 UTC) #16
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/ba39aa11d397ca1768ae2a702bec32aab9283770 Cr-Commit-Position: refs/heads/master@{#422818}
4 years, 2 months ago (2016-10-04 16:06:49 UTC) #18
dominickn
4 years, 2 months ago (2016-10-05 02:12:12 UTC) #19
Message was sent while issue was closed.
On 2016/10/04 16:06:49, commit-bot: I haz the power wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/ba39aa11d397ca1768ae2a702bec32aab9283770
> Cr-Commit-Position: refs/heads/master@{#422818}

This can result in utterly mysterious presubmit failures in the CQ if your tree
doesn't have this commit and you submit Java files with the old import ordering
(e.g. crrev.com/2351113005).

It took me quite a while to track down that checkstyle had changed. Can this be
advertised in some way? And for those of us who don't use eclim or Eclipse, is
there some canonical way to get the order right other than guesswork?

Powered by Google App Engine
This is Rietveld 408576698