third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp - Issue 2052783002: Accessibility objects with layers shouldn't be ignored

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp

Issue 2052783002: Accessibility objects with layers shouldn't be ignored (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/accessibility/canvas-description-and-role.html ('K') | « third_party/WebKit/LayoutTests/accessibility/canvas-description-and-role.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp

diff --git a/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp b/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp

index 6eb6d63f455602da8572e90be9085fa0fc647fed..0859599ec6af839432b93022284df4a9cc7c0d9e 100644

--- a/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp

+++ b/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp

@@ -582,6 +582,10 @@ bool AXLayoutObject::computeAccessibilityIsIgnored(IgnoredReasons* ignoredReason

if (m_layoutObject->isLayoutPart())

return false;

+ // Make sure renderers with layers stay in the tree.

+ if (getLayoutObject() && getLayoutObject()->hasLayer() && getNode() && getNode()->hasChildren())

+ return false;

// find out if this element is inside of a label element.

// if so, it may be ignored because it's the label for a checkbox or radio button

AXObject* controlObject = correspondingControlForLabelElement();