Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1295)

Unified Diff: src/objects.h

Issue 2052763003: [ic] [stubs] Remove InlineCacheState field from the code flags. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebasing Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ic/stub-cache.cc ('k') | src/objects.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.h
diff --git a/src/objects.h b/src/objects.h
index 5a010b51c9ca899c5e8b1409b41d81851d9a979e..0540bc0c6825088a76d30d6bcc88a1a496b712ed 100644
--- a/src/objects.h
+++ b/src/objects.h
@@ -4969,7 +4969,6 @@ class Code: public HeapObject {
// [flags]: Access to specific code flags.
inline Kind kind();
- inline InlineCacheState ic_state(); // Only valid for IC stubs.
inline ExtraICState extra_ic_state(); // Only valid for IC stubs.
// Testers for IC stub kinds.
@@ -4982,7 +4981,6 @@ class Code: public HeapObject {
inline bool is_to_boolean_ic_stub();
inline bool is_optimized_code();
inline bool is_wasm_code();
- inline bool embeds_maps_weakly();
inline bool IsCodeStubOrIC();
@@ -5105,18 +5103,12 @@ class Code: public HeapObject {
// Flags operations.
static inline Flags ComputeFlags(
- Kind kind, InlineCacheState ic_state = UNINITIALIZED,
- ExtraICState extra_ic_state = kNoExtraICState,
- CacheHolderFlag holder = kCacheOnReceiver);
-
- static inline Flags ComputeMonomorphicFlags(
Kind kind, ExtraICState extra_ic_state = kNoExtraICState,
CacheHolderFlag holder = kCacheOnReceiver);
static inline Flags ComputeHandlerFlags(
Kind handler_kind, CacheHolderFlag holder = kCacheOnReceiver);
- static inline InlineCacheState ExtractICStateFromFlags(Flags flags);
static inline CacheHolderFlag ExtractCacheHolderFromFlags(Flags flags);
static inline Kind ExtractKindFromFlags(Flags flags);
static inline ExtraICState ExtractExtraICStateFromFlags(Flags flags);
@@ -5288,12 +5280,11 @@ class Code: public HeapObject {
class ProfilerTicksField : public BitField<int, 4, 28> {};
// Flags layout. BitField<type, shift, size>.
- class ICStateField : public BitField<InlineCacheState, 0, 3> {};
- class CacheHolderField : public BitField<CacheHolderFlag, 3, 2> {};
- class KindField : public BitField<Kind, 5, 5> {};
- class ExtraICStateField
- : public BitField<ExtraICState, 10, PlatformSmiTagging::kSmiValueSize -
- 10 + 1> {}; // NOLINT
+ class CacheHolderField : public BitField<CacheHolderFlag, 0, 2> {};
+ class KindField : public BitField<Kind, CacheHolderField::kNext, 5> {};
+ class ExtraICStateField : public BitField<ExtraICState, KindField::kNext,
+ PlatformSmiTagging::kSmiValueSize -
+ KindField::kNext + 1> {};
// KindSpecificFlags1 layout (STUB, BUILTIN and OPTIMIZED_FUNCTION)
static const int kStackSlotsFirstBit = 0;
« no previous file with comments | « src/ic/stub-cache.cc ('k') | src/objects.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698