src/debug/mips/debug-mips.cc - Issue 2052763003: [ic] [stubs] Remove InlineCacheState field from the code flags.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/debug/mips/debug-mips.cc

Issue 2052763003: [ic] [stubs] Remove InlineCacheState field from the code flags. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Rebasing Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/debug/mips/debug-mips.cc

diff --git a/src/debug/mips/debug-mips.cc b/src/debug/mips/debug-mips.cc

index 8e00d61ef5dfd31653f986b2bfd57417df0ba93b..49320d8a815489e4332a3adb93f645e1c49f55b1 100644

--- a/src/debug/mips/debug-mips.cc

+++ b/src/debug/mips/debug-mips.cc

@@ -41,7 +41,7 @@ void DebugCodegen::ClearDebugBreakSlot(Isolate* isolate, Address pc) {

void DebugCodegen::PatchDebugBreakSlot(Isolate* isolate, Address pc,

Handle<Code> code) {

- DCHECK_EQ(Code::BUILTIN, code->kind());

+ DCHECK(code->is_debug_stub());

CodePatcher patcher(isolate, pc, Assembler::kDebugBreakSlotInstructions);

// Patch the code changing the debug break slot code from:

// nop(DEBUG_BREAK_NOP) - nop(1) is sll(zero_reg, zero_reg, 1)

« no previous file with comments | « src/debug/ia32/debug-ia32.cc ('k') | src/debug/mips64/debug-mips64.cc » ('j') | no next file with comments »