[ic] [stubs] Remove InlineCacheState field from the code flags.

[ic] [stubs] Remove InlineCacheState field from the code flags.

There are no ICs left that store their state in this field: vector based
ICs use feedback vector and the rest three (BinaryOpIC, CompareIC and
ToBooleanIC) reconstruct their state from the ExtraICState field.

This CL also removes unused InlineCacheState::DEBUG_STUB which was used
mostly in Code::is_debug_stub(). The latter now checks if the code is one
of the debug builtins instead.

BUG=chromium:618701
LOG=Y

Committed: https://crrev.com/9dc62d2721bb35178d60d10c52d4f84daff03c78
Cr-Commit-Position: refs/heads/master@{#36871}

[Igor Sheludko, 2016-06-09 09:20:02]

Patchset #1 (id:1) has been deleted

[Igor Sheludko, 2016-06-09 09:23:58]

Description was changed from

==========
[ic] [stubs] Remove InlineCacheState field from the code flags.

There are no ICs left that store their state in this field: vector based
ICs use feedback vector and the rest three (BinaryOpIC, CompareIC and
ToBooleanIC) reconstruct their state from the ExtraICState field.
==========

to

==========
[ic] [stubs] Remove InlineCacheState field from the code flags.

There are no ICs left that store their state in this field: vector based
ICs use feedback vector and the rest three (BinaryOpIC, CompareIC and
ToBooleanIC) reconstruct their state from the ExtraICState field.

This CL also removes unused InlineCacheState::DEBUG_STUB and introduces
Code::Kind::DEBUG_STUB instead.
==========

[Igor Sheludko, 2016-06-09 09:39:35]

Patchset #1 (id:20001) has been deleted

[Igor Sheludko, 2016-06-09 09:39:42]

Patchset #1 (id:40001) has been deleted

[Igor Sheludko, 2016-06-09 09:39:47]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-09 09:39:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2052763003/60001

[commit-bot: I haz the power, 2016-06-09 09:43:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-09 09:43:08]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/7000)
  v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_nodcheck_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)

[Igor Sheludko, 2016-06-09 11:29:28]

Patchset #1 (id:60001) has been deleted

[Igor Sheludko, 2016-06-09 11:29:36]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-09 11:29:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2052763003/80001

[commit-bot: I haz the power, 2016-06-09 11:33:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-09 11:33:26]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux_arm64_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/6984)
  v8_mac_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/2909)

[Igor Sheludko, 2016-06-09 11:49:24]

Patchset #1 (id:80001) has been deleted

[Igor Sheludko, 2016-06-09 11:49:31]

Patchset #1 (id:100001) has been deleted

[Igor Sheludko, 2016-06-09 11:49:37]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-09 11:49:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2052763003/120001

[Igor Sheludko, 2016-06-09 11:50:18]

ishell@chromium.org changed reviewers:
+ verwaest@chromium.org

[Igor Sheludko, 2016-06-09 11:50:18]

PTAL

[Igor Sheludko, 2016-06-09 11:54:53]

Description was changed from

==========
[ic] [stubs] Remove InlineCacheState field from the code flags.

There are no ICs left that store their state in this field: vector based
ICs use feedback vector and the rest three (BinaryOpIC, CompareIC and
ToBooleanIC) reconstruct their state from the ExtraICState field.

This CL also removes unused InlineCacheState::DEBUG_STUB and introduces
Code::Kind::DEBUG_STUB instead.
==========

to

==========
[ic] [stubs] Remove InlineCacheState field from the code flags.

There are no ICs left that store their state in this field: vector based
ICs use feedback vector and the rest three (BinaryOpIC, CompareIC and
ToBooleanIC) reconstruct their state from the ExtraICState field.

This CL also removes unused InlineCacheState::DEBUG_STUB and introduces
Code::Kind::DEBUG_STUB instead in order to detect when IC is replaced 
with debug stub.
==========

[commit-bot: I haz the power, 2016-06-09 12:22:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-09 12:22:07]

Dry run: This issue passed the CQ dry run.

[Toon Verwaest, 2016-06-09 13:49:12]

awesome cleanup!

https://codereview.chromium.org/2052763003/diff/120001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/2052763003/diff/120001/src/objects.cc#newcode...
src/objects.cc:13961: return UNINITIALIZED;
This looks weird, this case should be unreachable probably?
What about making this private to ic.cc?

[Igor Sheludko, 2016-06-09 14:56:23]

Description was changed from

==========
[ic] [stubs] Remove InlineCacheState field from the code flags.

There are no ICs left that store their state in this field: vector based
ICs use feedback vector and the rest three (BinaryOpIC, CompareIC and
ToBooleanIC) reconstruct their state from the ExtraICState field.

This CL also removes unused InlineCacheState::DEBUG_STUB and introduces
Code::Kind::DEBUG_STUB instead in order to detect when IC is replaced 
with debug stub.
==========

to

==========
[ic] [stubs] Remove InlineCacheState field from the code flags.

There are no ICs left that store their state in this field: vector based
ICs use feedback vector and the rest three (BinaryOpIC, CompareIC and
ToBooleanIC) reconstruct their state from the ExtraICState field.

This CL also removes unused InlineCacheState::DEBUG_STUB.

BUG=chromium:618701
LOG=Y
==========

[Igor Sheludko, 2016-06-09 15:13:52]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-09 15:14:02]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2052763003/140001

[Igor Sheludko, 2016-06-09 15:18:21]

Addressed comments

https://codereview.chromium.org/2052763003/diff/120001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/2052763003/diff/120001/src/objects.cc#newcode...
src/objects.cc:13961: return UNINITIALIZED;
On 2016/06/09 13:49:12, Toon Verwaest wrote:
> This looks weird, this case should be unreachable probably?
> What about making this private to ic.cc?

Done.

[Toon Verwaest, 2016-06-09 15:29:09]

Even better, lgtm

[commit-bot: I haz the power, 2016-06-09 15:45:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-09 15:45:02]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2016-06-09 15:47:48]

Description was changed from

==========
[ic] [stubs] Remove InlineCacheState field from the code flags.

There are no ICs left that store their state in this field: vector based
ICs use feedback vector and the rest three (BinaryOpIC, CompareIC and
ToBooleanIC) reconstruct their state from the ExtraICState field.

This CL also removes unused InlineCacheState::DEBUG_STUB.

BUG=chromium:618701
LOG=Y
==========

to

==========
[ic] [stubs] Remove InlineCacheState field from the code flags.

There are no ICs left that store their state in this field: vector based
ICs use feedback vector and the rest three (BinaryOpIC, CompareIC and
ToBooleanIC) reconstruct their state from the ExtraICState field.

This CL also removes unused InlineCacheState::DEBUG_STUB which was used 
mostly in Code::is_debug_stub(). The latter now checks if the code is one
of the debug builtins instead.

BUG=chromium:618701
LOG=Y
==========

[Igor Sheludko, 2016-06-09 15:47:59]

The CQ bit was checked by ishell@chromium.org

[commit-bot: I haz the power, 2016-06-09 15:48:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2052763003/140001

[commit-bot: I haz the power, 2016-06-09 15:50:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-09 15:50:42]

Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/16887)

[Igor Sheludko, 2016-06-09 16:16:24]

The CQ bit was checked by ishell@chromium.org

[Igor Sheludko, 2016-06-09 16:16:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
verwaest@chromium.org
Link to the patchset: https://codereview.chromium.org/2052763003/#ps160001
(title: "Rebasing")

[commit-bot: I haz the power, 2016-06-09 16:16:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2052763003/160001

[commit-bot: I haz the power, 2016-06-09 16:46:25]

Description was changed from

==========
[ic] [stubs] Remove InlineCacheState field from the code flags.

There are no ICs left that store their state in this field: vector based
ICs use feedback vector and the rest three (BinaryOpIC, CompareIC and
ToBooleanIC) reconstruct their state from the ExtraICState field.

This CL also removes unused InlineCacheState::DEBUG_STUB which was used 
mostly in Code::is_debug_stub(). The latter now checks if the code is one
of the debug builtins instead.

BUG=chromium:618701
LOG=Y
==========

to

==========
[ic] [stubs] Remove InlineCacheState field from the code flags.

There are no ICs left that store their state in this field: vector based
ICs use feedback vector and the rest three (BinaryOpIC, CompareIC and
ToBooleanIC) reconstruct their state from the ExtraICState field.

This CL also removes unused InlineCacheState::DEBUG_STUB which was used 
mostly in Code::is_debug_stub(). The latter now checks if the code is one
of the debug builtins instead.

BUG=chromium:618701
LOG=Y
==========

[commit-bot: I haz the power, 2016-06-09 16:46:26]

Committed patchset #3 (id:160001)

[commit-bot: I haz the power, 2016-06-09 16:49:10]

Description was changed from

==========
[ic] [stubs] Remove InlineCacheState field from the code flags.

There are no ICs left that store their state in this field: vector based
ICs use feedback vector and the rest three (BinaryOpIC, CompareIC and
ToBooleanIC) reconstruct their state from the ExtraICState field.

This CL also removes unused InlineCacheState::DEBUG_STUB which was used 
mostly in Code::is_debug_stub(). The latter now checks if the code is one
of the debug builtins instead.

BUG=chromium:618701
LOG=Y
==========

to

==========
[ic] [stubs] Remove InlineCacheState field from the code flags.

There are no ICs left that store their state in this field: vector based
ICs use feedback vector and the rest three (BinaryOpIC, CompareIC and
ToBooleanIC) reconstruct their state from the ExtraICState field.

This CL also removes unused InlineCacheState::DEBUG_STUB which was used
mostly in Code::is_debug_stub(). The latter now checks if the code is one
of the debug builtins instead.

BUG=chromium:618701
LOG=Y

Committed: https://crrev.com/9dc62d2721bb35178d60d10c52d4f84daff03c78
Cr-Commit-Position: refs/heads/master@{#36871}
==========

[commit-bot: I haz the power, 2016-06-09 16:49:11]

Patchset 3 (id:??) landed as
https://crrev.com/9dc62d2721bb35178d60d10c52d4f84daff03c78
Cr-Commit-Position: refs/heads/master@{#36871}