Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2052753002:
[telemetry] Add new tracing benchmark for background mode memory-infra (Closed)
|
Created:
4 years, 6 months ago by ssid Modified:
4 years, 6 months ago Reviewers:
Zhen Wang CC:
chromium-reviews, telemetry-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@browsertest_background Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[telemetry] Add new tracing benchmark for background mode memory-infra
The memory infra category cannot be included in existing tracing
benchmark because it creates large memory dumps in single event in
"DETAILED" mode, so it changes the metrics measured. The memory-infra
cannot be turned on just for "BACKGROUND" or "LIGHT" mode since the
reference builds do not support the Tracing.Start api with trace config
or the background mode at all. We also do not want to disable the
tracing benchmark on reference builds. So, new benchamrk is added to
measure overhead of memory-infra in background mode.
The trcaingMetrics contains the metrics needs to track the overhead of
memory infra in the traces, so the bencmark just tracks the
tracingMetrics.
BUG=618514
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq
Committed: https://crrev.com/d07de96446e595c4a810b592fedcb8bc026c9551
Cr-Commit-Position: refs/heads/master@{#400628}
Patch Set 1 : #Patch Set 2 : Depend on browsertest cl. #Patch Set 3 : nit. #Patch Set 4 : rebase. #Patch Set 5 : new benchmark. #
Total comments: 6
Patch Set 6 : Fix comment and todo. #Messages
Total messages: 33 (17 generated)
Description was changed from ========== [telemetry] Add memory-infra category to tracing benchmark The tracing benchmark now includes the memory-infra category. The trcaingMetrics contains the metrics needs to track the overhead of memory infra in the traces. BUG=618514 ========== to ========== [telemetry] Add memory-infra category to tracing benchmark The tracing benchmark now includes the memory-infra category. The trcaingMetrics contains the metrics needs to track the overhead of memory infra in the traces. BUG=618514 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ==========
Description was changed from ========== [telemetry] Add memory-infra category to tracing benchmark The tracing benchmark now includes the memory-infra category. The trcaingMetrics contains the metrics needs to track the overhead of memory infra in the traces. BUG=618514 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ========== to ========== [telemetry] Add memory-infra category to tracing benchmark The tracing benchmark now includes the memory-infra category. The trcaingMetrics contains the metrics needs to track the overhead of memory infra in the traces. This CL adds periodic memory infra background mode dumps to this benchmark. BUG=618514 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ==========
Patchset #1 (id:1) has been deleted
ssid@chromium.org changed reviewers: + zhenw@chromium.org
+Zhen, Please review this CL along with https://codereview.chromium.org/2043203003/. Thanks.
lgtm Please add the owner to go/perf-owners. Just find the benchmark name and edit the owner's field.
On 2016/06/13 18:05:22, Zhen Wang wrote: > lgtm > > Please add the owner to go/perf-owners. Just find the benchmark name and edit > the owner's field. Thanks, added myself to the field.
The CQ bit was checked by ssid@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2052753002/70001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_retina_perf_cq on tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_retina_perf_...)
Description was changed from ========== [telemetry] Add memory-infra category to tracing benchmark The tracing benchmark now includes the memory-infra category. The trcaingMetrics contains the metrics needs to track the overhead of memory infra in the traces. This CL adds periodic memory infra background mode dumps to this benchmark. BUG=618514 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ========== to ========== [telemetry] Add new tracing benchmark for background mode memory-infra The memory infra category cannot be included in existing tracing benchmark because it creates large memory dumps in single event in "DETAILED" mode, so it changes the metrics measured. The memory-infra cannot be turned on just for "BACKGROUND" or "LIGHT" mode since the reference builds do not support the Tracing.Start api with trace config or the background mode at all. We also do not want to disable the tracing benchmark on reference builds. The trcaingMetrics contains the metrics needs to track the overhead of memory infra in the traces, so the bencmark just tracks the tracingMetrics. BUG=61851 ==========
Description was changed from ========== [telemetry] Add new tracing benchmark for background mode memory-infra The memory infra category cannot be included in existing tracing benchmark because it creates large memory dumps in single event in "DETAILED" mode, so it changes the metrics measured. The memory-infra cannot be turned on just for "BACKGROUND" or "LIGHT" mode since the reference builds do not support the Tracing.Start api with trace config or the background mode at all. We also do not want to disable the tracing benchmark on reference builds. The trcaingMetrics contains the metrics needs to track the overhead of memory infra in the traces, so the bencmark just tracks the tracingMetrics. BUG=61851 ========== to ========== [telemetry] Add new tracing benchmark for background mode memory-infra The memory infra category cannot be included in existing tracing benchmark because it creates large memory dumps in single event in "DETAILED" mode, so it changes the metrics measured. The memory-infra cannot be turned on just for "BACKGROUND" or "LIGHT" mode since the reference builds do not support the Tracing.Start api with trace config or the background mode at all. We also do not want to disable the tracing benchmark on reference builds. So, new benchamrk is added to measure overhead of memory-infra in background mode. The trcaingMetrics contains the metrics needs to track the overhead of memory infra in the traces, so the bencmark just tracks the tracingMetrics. BUG=618514 ==========
Description was changed from ========== [telemetry] Add new tracing benchmark for background mode memory-infra The memory infra category cannot be included in existing tracing benchmark because it creates large memory dumps in single event in "DETAILED" mode, so it changes the metrics measured. The memory-infra cannot be turned on just for "BACKGROUND" or "LIGHT" mode since the reference builds do not support the Tracing.Start api with trace config or the background mode at all. We also do not want to disable the tracing benchmark on reference builds. So, new benchamrk is added to measure overhead of memory-infra in background mode. The trcaingMetrics contains the metrics needs to track the overhead of memory infra in the traces, so the bencmark just tracks the tracingMetrics. BUG=618514 ========== to ========== [telemetry] Add new tracing benchmark for background mode memory-infra The memory infra category cannot be included in existing tracing benchmark because it creates large memory dumps in single event in "DETAILED" mode, so it changes the metrics measured. The memory-infra cannot be turned on just for "BACKGROUND" or "LIGHT" mode since the reference builds do not support the Tracing.Start api with trace config or the background mode at all. We also do not want to disable the tracing benchmark on reference builds. So, new benchamrk is added to measure overhead of memory-infra in background mode. The trcaingMetrics contains the metrics needs to track the overhead of memory infra in the traces, so the bencmark just tracks the tracingMetrics. BUG=618514 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ==========
The CQ bit was checked by ssid@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2052753002/90001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: winx64_10_perf_cq on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
Zhen, Could you please take another look. I have added a new benchmark disabled on reference builds instead of using the old one. Sorry for the back and forth
https://codereview.chromium.org/2052753002/diff/90001/tools/perf/benchmarks/t... File tools/perf/benchmarks/tracing.py (right): https://codereview.chromium.org/2052753002/diff/90001/tools/perf/benchmarks/t... tools/perf/benchmarks/tracing.py:30: # Enable on reference builds once stable browser starts supporting background Can you add it as TODO here? https://codereview.chromium.org/2052753002/diff/90001/tools/perf/benchmarks/t... tools/perf/benchmarks/tracing.py:34: """Measures the timeline metrics for overhead of background memory-infra This should be one line. Then followed by detailed description if needed. https://codereview.chromium.org/2052753002/diff/90001/tools/perf/benchmarks/t... tools/perf/benchmarks/tracing.py:42: filter_string='-*,blink.console,disabled-by-default-memory-infra') What does "-*" mean here?
Thanks, please see replies inline. https://codereview.chromium.org/2052753002/diff/90001/tools/perf/benchmarks/t... File tools/perf/benchmarks/tracing.py (right): https://codereview.chromium.org/2052753002/diff/90001/tools/perf/benchmarks/t... tools/perf/benchmarks/tracing.py:30: # Enable on reference builds once stable browser starts supporting background On 2016/06/17 19:45:22, Zhen Wang wrote: > Can you add it as TODO here? Done. https://codereview.chromium.org/2052753002/diff/90001/tools/perf/benchmarks/t... tools/perf/benchmarks/tracing.py:34: """Measures the timeline metrics for overhead of background memory-infra On 2016/06/17 19:45:22, Zhen Wang wrote: > This should be one line. Then followed by detailed description if needed. Done. https://codereview.chromium.org/2052753002/diff/90001/tools/perf/benchmarks/t... tools/perf/benchmarks/tracing.py:42: filter_string='-*,blink.console,disabled-by-default-memory-infra') On 2016/06/17 19:45:22, Zhen Wang wrote: > What does "-*" mean here? -* means it excludes all the default categories. This is the same pattern followed here: https://chromium.googlesource.com/chromium/src/+/master/tools/perf/benchmarks...
lgtm
The CQ bit was checked by ssid@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2052753002/110001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: winx64_10_perf_cq on tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64_10_perf_c...)
Description was changed from ========== [telemetry] Add new tracing benchmark for background mode memory-infra The memory infra category cannot be included in existing tracing benchmark because it creates large memory dumps in single event in "DETAILED" mode, so it changes the metrics measured. The memory-infra cannot be turned on just for "BACKGROUND" or "LIGHT" mode since the reference builds do not support the Tracing.Start api with trace config or the background mode at all. We also do not want to disable the tracing benchmark on reference builds. So, new benchamrk is added to measure overhead of memory-infra in background mode. The trcaingMetrics contains the metrics needs to track the overhead of memory infra in the traces, so the bencmark just tracks the tracingMetrics. BUG=618514 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ========== to ========== [telemetry] Add new tracing benchmark for background mode memory-infra The memory infra category cannot be included in existing tracing benchmark because it creates large memory dumps in single event in "DETAILED" mode, so it changes the metrics measured. The memory-infra cannot be turned on just for "BACKGROUND" or "LIGHT" mode since the reference builds do not support the Tracing.Start api with trace config or the background mode at all. We also do not want to disable the tracing benchmark on reference builds. So, new benchamrk is added to measure overhead of memory-infra in background mode. The trcaingMetrics contains the metrics needs to track the overhead of memory infra in the traces, so the bencmark just tracks the tracingMetrics. BUG=618514 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ==========
The CQ bit was checked by ssid@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2052753002/110001
Message was sent while issue was closed.
Description was changed from ========== [telemetry] Add new tracing benchmark for background mode memory-infra The memory infra category cannot be included in existing tracing benchmark because it creates large memory dumps in single event in "DETAILED" mode, so it changes the metrics measured. The memory-infra cannot be turned on just for "BACKGROUND" or "LIGHT" mode since the reference builds do not support the Tracing.Start api with trace config or the background mode at all. We also do not want to disable the tracing benchmark on reference builds. So, new benchamrk is added to measure overhead of memory-infra in background mode. The trcaingMetrics contains the metrics needs to track the overhead of memory infra in the traces, so the bencmark just tracks the tracingMetrics. BUG=618514 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ========== to ========== [telemetry] Add new tracing benchmark for background mode memory-infra The memory infra category cannot be included in existing tracing benchmark because it creates large memory dumps in single event in "DETAILED" mode, so it changes the metrics measured. The memory-infra cannot be turned on just for "BACKGROUND" or "LIGHT" mode since the reference builds do not support the Tracing.Start api with trace config or the background mode at all. We also do not want to disable the tracing benchmark on reference builds. So, new benchamrk is added to measure overhead of memory-infra in background mode. The trcaingMetrics contains the metrics needs to track the overhead of memory infra in the traces, so the bencmark just tracks the tracingMetrics. BUG=618514 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ==========
Message was sent while issue was closed.
Committed patchset #6 (id:110001)
Message was sent while issue was closed.
Description was changed from ========== [telemetry] Add new tracing benchmark for background mode memory-infra The memory infra category cannot be included in existing tracing benchmark because it creates large memory dumps in single event in "DETAILED" mode, so it changes the metrics measured. The memory-infra cannot be turned on just for "BACKGROUND" or "LIGHT" mode since the reference builds do not support the Tracing.Start api with trace config or the background mode at all. We also do not want to disable the tracing benchmark on reference builds. So, new benchamrk is added to measure overhead of memory-infra in background mode. The trcaingMetrics contains the metrics needs to track the overhead of memory infra in the traces, so the bencmark just tracks the tracingMetrics. BUG=618514 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ========== to ========== [telemetry] Add new tracing benchmark for background mode memory-infra The memory infra category cannot be included in existing tracing benchmark because it creates large memory dumps in single event in "DETAILED" mode, so it changes the metrics measured. The memory-infra cannot be turned on just for "BACKGROUND" or "LIGHT" mode since the reference builds do not support the Tracing.Start api with trace config or the background mode at all. We also do not want to disable the tracing benchmark on reference builds. So, new benchamrk is added to measure overhead of memory-infra in background mode. The trcaingMetrics contains the metrics needs to track the overhead of memory infra in the traces, so the bencmark just tracks the tracingMetrics. BUG=618514 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq Committed: https://crrev.com/d07de96446e595c4a810b592fedcb8bc026c9551 Cr-Commit-Position: refs/heads/master@{#400628} ==========
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/d07de96446e595c4a810b592fedcb8bc026c9551 Cr-Commit-Position: refs/heads/master@{#400628} |
